From: Thomas Huth <thuth@redhat.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
qemu-riscv@nongnu.org,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Bin Meng <bmeng@tinylab.org>,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: tests/avocado/riscv_opensbi.py does not work reliable
Date: Tue, 3 Sep 2024 07:55:01 +0200 [thread overview]
Message-ID: <367c2564-4920-4eb4-88e2-7ffa68f1c7ac@redhat.com> (raw)
In-Reply-To: <CAKmqyKNk2u0ApN2PV40EX_tsY8cFD56XcSKhyepQbqzEdP4_zQ@mail.gmail.com>
On 03/09/2024 01.54, Alistair Francis wrote:
> On Sat, Aug 31, 2024 at 1:35 AM Thomas Huth <thuth@redhat.com> wrote:
>>
>>
>> Hi!
>>
>> While running a lot of tests (i.e. with a very loaded machine), I noticed
>> that tests/avocado/riscv_opensbi.py is very flaky when the host machine is
>> slow. I can easily reproduce the problem when running a big compilation job
>> on all CPUs in the background and then run the riscv_opensbi.py avocado
>> test. One of test_riscv32_spike, test_riscv64_spike, test_riscv32_sifive_u
>> or test_riscv64_sifive_u is failing most of the time (but not the virt
>> machine tests).
>>
>> Looking at the logs, it seems like the output sometimes stops somewhere at a
>> random place before the boot process reaches the spot that the test is
>> looking for. Looking at riscv_htif.c, there does not seem to be any flow
>
> I suspect this is: https://gitlab.com/qemu-project/qemu/-/issues/2114
Indeed, that looks like the same issue - I should have had a look at the bug
tracker first!
>> control implemented here, so I guess at least the spike test is currently
>> doomed to fail occasionally. Is there anything that can be done about this
>> (e.g. is flow control somehow possible here or does the interface not allow
>> this?)? Otherwise, I think it might be best to mark the spike and sifive_u
>
> Patches have been sent to the list to hopefully fix this:
>
> https://mail.gnu.org/archive/html/qemu-devel/2024-08/msg02743.html
>
> Just waiting on reviews and then the merge window to open up again
Thanks a lot, these patches are fixing the issues for me!
Thomas
prev parent reply other threads:[~2024-09-03 5:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 15:34 tests/avocado/riscv_opensbi.py does not work reliable Thomas Huth
2024-09-02 23:54 ` Alistair Francis
2024-09-03 5:55 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=367c2564-4920-4eb4-88e2-7ffa68f1c7ac@redhat.com \
--to=thuth@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).