From: Max Reitz <mreitz@redhat.com>
To: jemmy858585@gmail.com, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org,
Lidong Chen <lidongchen@tencent.com>
Subject: Re: [Qemu-devel] [PATCH v3] qemu-img: use blk_co_pwrite_zeroes for zero sectors when compressed
Date: Fri, 28 Apr 2017 18:19:41 +0200 [thread overview]
Message-ID: <3684ce67-a2c0-01ee-b1d2-d96f1b45b8a2@redhat.com> (raw)
In-Reply-To: <1493261907-18734-1-git-send-email-lidongchen@tencent.com>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On 27.04.2017 04:58, jemmy858585@gmail.com wrote:
> From: Lidong Chen <lidongchen@tencent.com>
>
> When the buffer is zero, blk_co_pwrite_zeroes is more effective than
> blk_co_pwritev with BDRV_REQ_WRITE_COMPRESSED. This patch can reduce
> the time for converting qcow2 images with lots of zero data.
>
> Signed-off-by: Lidong Chen <lidongchen@tencent.com>
> ---
> v3 changelog:
> fix some spelling errors and code style.
> v2 changelog:
> unify the compressed and non-compressed code paths.
> ---
> qemu-img.c | 44 ++++++++++++++------------------------------
> 1 file changed, 14 insertions(+), 30 deletions(-)
Thank you, I have applied the patch to my block branch:
https://github.com/XanClic/qemu/commits/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
prev parent reply other threads:[~2017-04-28 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 2:58 [Qemu-devel] [PATCH v3] qemu-img: use blk_co_pwrite_zeroes for zero sectors when compressed jemmy858585
2017-04-27 3:39 ` no-reply
2017-04-28 16:19 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3684ce67-a2c0-01ee-b1d2-d96f1b45b8a2@redhat.com \
--to=mreitz@redhat.com \
--cc=jemmy858585@gmail.com \
--cc=kwolf@redhat.com \
--cc=lidongchen@tencent.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).