From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tests/Makefile.include: test all rounding modes of softfloat
Date: Mon, 25 Feb 2019 07:40:53 -0800 [thread overview]
Message-ID: <36a53b88-11cb-0206-9e4c-8a9fa174fe31@linaro.org> (raw)
In-Reply-To: <20190224151553.31344-1-alex.bennee@linaro.org>
On 2/24/19 7:15 AM, Alex Bennée wrote:
> We missed a bug in a recent patch as we were not testing all the
> rounding modes for all operations. However enabling all rounding modes
> for mulAdd does slow down the already slowest test and doesn't really
> buy us much additional coverage so lets allow the default test flags
> to be overridden.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/Makefile.include | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2019-02-25 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 15:15 [Qemu-devel] [PATCH] tests/Makefile.include: test all rounding modes of softfloat Alex Bennée
2019-02-25 15:40 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36a53b88-11cb-0206-9e4c-8a9fa174fe31@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).