From: Thomas Huth <thuth@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Jens Freimann <jfreimann@redhat.com>,
Juan Quintela <quintela@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v8 0/4] tests/qtest: add some tests for virtio-net failover
Date: Thu, 9 Dec 2021 11:24:07 +0100 [thread overview]
Message-ID: <36c15126-b63b-742d-d2c6-f81fc0138252@redhat.com> (raw)
In-Reply-To: <20211208130350.10178-1-lvivier@redhat.com>
On 08/12/2021 14.03, Laurent Vivier wrote:
> This series adds a qtest entry to test virtio-net failover feature.
>
> We check following error cases:
>
> - check missing id on device with failover_pair_id triggers an error
> - check a primary device plugged on a bus that doesn't support hotplug
> triggers an error
>
> We check the status of the machine before and after hotplugging cards and
> feature negotiation:
>
> - check we don't see the primary device at boot if failover is on
> - check we see the primary device at boot if failover is off
> - check we don't see the primary device if failover is on
> but failover_pair_id is not the one with on (I think this should be changed)
> - check the primary device is plugged after the feature negotiation
> - check the result if the primary device is plugged before standby device and
> vice-versa
> - check the if the primary device is coldplugged and the standy device
> hotplugged and vice-versa
> - check the migration triggers the unplug and the hotplug
>
> There is one preliminary patch in the series:
>
> - PATCH 1 introduces a function to enable PCI bridge.
> Failover needs to be plugged on a pcie-root-port and while
> the root port is not configured the cards behind it are not
> available
>
> v8:
> - fix checkpatch.pl error (space after "(")
> - fix sanitizer errors:
> * migrate_status() qobject_unref() cleanup
> * release QVirtioPCIDevice with qos_object_destroy()
> * add a missing g_free() in qpci_secondary_buses_rec()
> * add qobject_unref() in get_bus() and find_device()
> when an object is popped from a list.
Thanks, CI is green now, so queued it to my testing-next branch:
https://gitlab.com/thuth/qemu/-/commits/testing-next/
Thomas
prev parent reply other threads:[~2021-12-09 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 13:03 [PATCH v8 0/4] tests/qtest: add some tests for virtio-net failover Laurent Vivier
2021-12-08 13:03 ` [PATCH v8 1/4] qtest/libqos: add a function to initialize secondary PCI buses Laurent Vivier
2021-12-08 13:03 ` [PATCH v8 2/4] tests/qtest: add some tests for virtio-net failover Laurent Vivier
2021-12-08 13:03 ` [PATCH v8 3/4] test/libqtest: add some virtio-net failover migration cancelling tests Laurent Vivier
2021-12-08 13:03 ` [PATCH v8 4/4] tests/libqtest: add a migration test with two couples of failover devices Laurent Vivier
2021-12-09 10:24 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36c15126-b63b-742d-d2c6-f81fc0138252@redhat.com \
--to=thuth@redhat.com \
--cc=jfreimann@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).