From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64F42C4363A for ; Thu, 22 Oct 2020 08:36:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D60EF21775 for ; Thu, 22 Oct 2020 08:36:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NFbV0DHY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D60EF21775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVW58-0006Fj-Q1 for qemu-devel@archiver.kernel.org; Thu, 22 Oct 2020 04:36:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVVvt-0006OR-Nj for qemu-devel@nongnu.org; Thu, 22 Oct 2020 04:26:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43993) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kVVvq-0006lJ-2E for qemu-devel@nongnu.org; Thu, 22 Oct 2020 04:26:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603355204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b9V03vMiGmGosvko6b2dJhxpCtCW5YXf3ZwW6PhBxQE=; b=NFbV0DHY2O+pmwofgvJcQEYeNsE2lQ0VSmLh5xS7LSJdLs7h+yVa92PZDNr5OM51SDbpZB fI0za191Yt7RWt/YryUZH6shIFrleKa8al+w+q7Cr2ARQ70jsPAxtbJSnQHQ/PNikap9Hn nHwVqQA6v2EOLYG1+1COfPv5su/ZTVo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-51-c2swcOsTMn-Llnu42PDX6A-1; Thu, 22 Oct 2020 04:26:42 -0400 X-MC-Unique: c2swcOsTMn-Llnu42PDX6A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B5C83ADC4C; Thu, 22 Oct 2020 08:26:32 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-77.ams2.redhat.com [10.36.112.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2A4171002EE8; Thu, 22 Oct 2020 08:26:20 +0000 (UTC) Subject: Re: [PATCH 1/2] s390x: pv: Remove sclp boundary checks To: Janosch Frank , qemu-devel@nongnu.org References: <20201021134345.110173-1-frankja@linux.ibm.com> <20201021134345.110173-2-frankja@linux.ibm.com> From: Thomas Huth Message-ID: <36e0ade5-117c-ffb3-3640-28f2a6138052@redhat.com> Date: Thu, 22 Oct 2020 10:26:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201021134345.110173-2-frankja@linux.ibm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/22 00:54:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: walling@linux.ibm.com, david@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, mhartmay@linux.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 21/10/2020 15.43, Janosch Frank wrote: > The SCLP boundary cross check is done by the Ultravisor for a > protected guest, hence we don't need to do it. As QEMU doesn't get a > valid SCCB address in protected mode this is even problematic and can > lead to QEMU reporting a false boundary cross error. > > Signed-off-by: Janosch Frank > Reported-by: Marc Hartmayer > Fixes: db13387ca0 ("s390/sclp: rework sclp boundary checks") > Reviewed-by: Christian Borntraeger > Tested-by: Marc Hartmayer > --- > hw/s390x/sclp.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c > index 00f1e4648d..0cf2290826 100644 > --- a/hw/s390x/sclp.c > +++ b/hw/s390x/sclp.c > @@ -285,11 +285,6 @@ int sclp_service_call_protected(CPUS390XState *env, uint64_t sccb, > goto out_write; > } > > - if (!sccb_verify_boundary(sccb, be16_to_cpu(work_sccb->h.length), code)) { > - work_sccb->h.response_code = cpu_to_be16(SCLP_RC_SCCB_BOUNDARY_VIOLATION); > - goto out_write; > - } > - > sclp_c->execute(sclp, work_sccb, code); > out_write: > s390_cpu_pv_mem_write(env_archcpu(env), 0, work_sccb, > Reviewed-by: Thomas Huth