From: Thomas Huth <thuth@redhat.com>
To: Samuel Thibault <samuel.thibault@gnu.org>,
Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] net/slirp: introduce slirp_os_socket to stay compatible with libslirp past 4.8.0
Date: Thu, 30 Jan 2025 11:09:56 +0100 [thread overview]
Message-ID: <36e2ee26-89ee-442b-85fa-015d919cc86f@redhat.com> (raw)
In-Reply-To: <Z5rgUDDB0X58-XZt@begin>
On 30/01/2025 03.13, Samuel Thibault wrote:
> Hello,
>
> Samuel Thibault, le jeu. 10 oct. 2024 01:06:47 +0200, a ecrit:
>> Michael Tokarev, le sam. 05 oct. 2024 10:07:53 +0300, a ecrit:
>>> libslirp introduced new typedef after 4.8.0, slirp_os_socket, which
>>> is defined to SOCKET on windows, which, in turn, is a 64bit number.
>>> qemu uses int, so callback function prorotypes changed.
>>
>> I have fixed the code in upstream libslirp, to avoid breaking the API
>> and ABI, and instead provide new functions & methods so that
>> qemu/libslirp can upgrade smoothly.
>
> It is now released in version 4.9.0 of libslirp.
Seems like 4.9.0 breaks the CI:
https://gitlab.com/thuth/qemu/-/jobs/8994301595#L4373
Could you please have a look?
Thanks,
Thomas
next prev parent reply other threads:[~2025-01-30 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 7:07 [PATCH] net/slirp: introduce slirp_os_socket to stay compatible with libslirp past 4.8.0 Michael Tokarev
2024-10-09 23:06 ` Samuel Thibault
2025-01-30 2:13 ` Samuel Thibault
2025-01-30 10:09 ` Thomas Huth [this message]
2025-01-30 10:12 ` Michael Tokarev
2025-01-30 10:15 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36e2ee26-89ee-442b-85fa-015d919cc86f@redhat.com \
--to=thuth@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@gnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).