From: Richard Henderson <richard.henderson@linaro.org>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
peter.maydell@linaro.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PULL v2 00/76] target/microblaze improvements
Date: Wed, 2 Sep 2020 19:12:24 -0700 [thread overview]
Message-ID: <36e36e04-cc04-163d-58ec-10314ed53999@linaro.org> (raw)
In-Reply-To: <ca9d4e58-3545-ca8e-6862-26efe81a0cc7@linaro.org>
On 9/2/20 4:11 PM, Richard Henderson wrote:
> On 9/2/20 12:09 PM, Thomas Huth wrote:
>> On 01/09/2020 17.20, Richard Henderson wrote:
>>> Version 2. Serves me right for not testing 32-bit host
>>> when I knew there was a patch that mattered.
>>
>> Hi Richard,
>>
>> I'm afraid, but I think this PR broke the
>> tests/acceptance/replay_kernel.py:ReplayKernel.test_microblaze_s3adsp1800 acceptance
>> test:
>>
>> https://gitlab.com/qemu-project/qemu/-/jobs/716158589#L176
>>
>> Could you please have a look?
>
> That's odd.
>
> Doesn't replay rely on migration (or at least VMStateDescription) to do its
> job? Microblaze doesn't implement that, so how could this have worked before?
>
> I admit that I don't often run check-acceptance, because I rarely see a clean
> bill of health, even for stuff I'm not working on.
>
> Looking into it...
Ah, in this case it's all about the icount setting.
So the log recorded by replay=record is indeed useless for input to
replay=replay, but not relevant.
r~
prev parent reply other threads:[~2020-09-03 2:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 15:20 [PULL v2 00/76] target/microblaze improvements Richard Henderson
2020-09-01 15:20 ` [PULL v2 58/76] tcg: Add tcg_get_insn_start_param Richard Henderson
2020-09-02 14:26 ` [PULL v2 00/76] target/microblaze improvements Peter Maydell
2020-09-02 19:09 ` Thomas Huth
2020-09-02 23:11 ` Richard Henderson
2020-09-03 2:12 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36e36e04-cc04-163d-58ec-10314ed53999@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).