From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCsmq-0002qW-0U for qemu-devel@nongnu.org; Tue, 14 Jun 2016 14:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCsmm-0001Dy-Pd for qemu-devel@nongnu.org; Tue, 14 Jun 2016 14:10:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCsmm-0001DR-Iw for qemu-devel@nongnu.org; Tue, 14 Jun 2016 14:10:00 -0400 References: <1465924093-76875-1-git-send-email-vsementsov@virtuozzo.com> From: Max Reitz Message-ID: <36eb593a-c423-94d9-3993-113be4d4f1c7@redhat.com> Date: Tue, 14 Jun 2016 20:09:57 +0200 MIME-Version: 1.0 In-Reply-To: <1465924093-76875-1-git-send-email-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TWV8wMCa1lioA5H5K7t55QFTjc0fW2p6u" Subject: Re: [Qemu-devel] [PATCH v2 0/2] block: fix libvirt snapshot with existing bitmaps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: den@openvz.org, kwolf@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TWV8wMCa1lioA5H5K7t55QFTjc0fW2p6u From: Max Reitz To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: den@openvz.org, kwolf@redhat.com Message-ID: <36eb593a-c423-94d9-3993-113be4d4f1c7@redhat.com> Subject: Re: [PATCH v2 0/2] block: fix libvirt snapshot with existing bitmaps References: <1465924093-76875-1-git-send-email-vsementsov@virtuozzo.com> In-Reply-To: <1465924093-76875-1-git-send-email-vsementsov@virtuozzo.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 14.06.2016 19:08, Vladimir Sementsov-Ogievskiy wrote: > v2: > - additional patch with asserts for hbitmap. As BdrvDirtyBitmap is onl= y > an interlayer here, I decided to plase asserts into HBitmap public > functions. > - add comment > - from Max's comments: > - assert after if block > - bitmap->size instead of bdrv_nb_sectors. It is not beautiful, but= > with bdrv_nb_sectors we have to handle error code here, which > would be worse I think. >=20 > Vladimir Sementsov-Ogievskiy (2): > hbitmap: add 'pos < size' asserts > block: fix libvirt snapshot with existing bitmaps >=20 > block/dirty-bitmap.c | 14 ++++++++++++++ > util/hbitmap.c | 3 +++ > 2 files changed, 17 insertions(+) Thanks Vladimir, I've applied the series to my block branch: https://github.com/XanClic/qemu/commits/block Max --TWV8wMCa1lioA5H5K7t55QFTjc0fW2p6u Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXYEh1AAoJEDuxQgLoOKytod0H/iHvxGEyDIHFi8WQNnhvddeR IF3Dl5fgk5AKCHX91Levhucyk5/Ry2U7eMRA1ksRBAHvwiotX2ekThMWx20iwaKg U03+wKUzmCA0nzsYuVwtjyOenm3hH2EY8OJ81sP6GWs+gsRQsnKKr82D7xr+UyTV eTYW/MDJOnHpOKA+FE8RSbiMnXMJe23hg9FbVoUwWVAMs7oMAZZ2tN+lmLMHtSb9 hR3OyfJw+FsanU1WJ5tnBRk/KHV42tXMz9SxXACBLSQbnliGya8AnoKAxSpEs/Ut 8QuV43ch6zhdHQsh7n/S9n6ibC2qlEAMmqQfbDtMobitLwP/+0WYYI0e66jIHRI= =D1GF -----END PGP SIGNATURE----- --TWV8wMCa1lioA5H5K7t55QFTjc0fW2p6u--