From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 132B6C0218D for ; Sun, 26 Jan 2025 20:39:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tc9Oe-0004sh-Ml; Sun, 26 Jan 2025 15:38:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tc9Od-0004s8-Gq for qemu-devel@nongnu.org; Sun, 26 Jan 2025 15:38:19 -0500 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tc9Oa-0001an-Af for qemu-devel@nongnu.org; Sun, 26 Jan 2025 15:38:19 -0500 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-2165448243fso81672405ad.1 for ; Sun, 26 Jan 2025 12:38:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737923895; x=1738528695; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=HVPb45ZdRMqIKUAi6GudayI0aNfKV1cv8oTD0Mxltf8=; b=cQX45JTG87bIB/kBpgvQgBBpOcJZlM9jxpS/iFgRByS1eHQ14jhuItKbMe2/DGMhRl 4WcPmt03g7ReBBkArswLd5YBsc+bRDu20aw5w18uwsV0fwAZ4GXrrFk7VA46GL9SlZxo sok++KoTZDZiQEe0pmZZVwYKm83PVfDxsQKCFw1ZJLGCMLWWdEeAtsWqljwaSTSLxStX 9UPNkfjHOqdaojQZYF2nIM+jMSa/LmMilOp3OgjVARl5XzFp+NFhmN1OzPxc7GIFGNCO t5UJl+FkBDVa+HfoBdPQfAmi3dqYkcfJBUjaK7/c5YQOv3P5slVoEBbdmgpZ+fFPEPM3 dT4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737923895; x=1738528695; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HVPb45ZdRMqIKUAi6GudayI0aNfKV1cv8oTD0Mxltf8=; b=LsShvbICJVJ34VpAH3JhFZtJ8cUzBhCIb3vX1DsFbPw5/MgiLMruoMfp1jJ6YYoiTE RLDoJsK4ZLozzrKWi08mKCbN+fDicaMEniPQVHBSXDh8oxtETba9dC0y93tv8nJSJxUv zTObJc4xvAP4v/ce350BJuZVhEeXU0Zs0fHFIuUFEfoXklRci4k0NNdpNJQqW+gPYipI BMLb1bTJwdB/LGiUlySOm5KfGA5xsLV1ssmYlxPB+A2GgMRVkGnMhXZsCmBnFQX8nCu3 iMSGyWSdhVoiSw4n2T1rRb+CIxk7agyYbVRm74I7bllelFPK3p3CjP2DA26VoeQROJNb baeA== X-Forwarded-Encrypted: i=1; AJvYcCWOZah7PZMiltW+CLgJwCRn5t/HfEsqor9tmU+DkfakeeHiJDmINB488BLdEBX42Uh/cCARDnKEPpmD@nongnu.org X-Gm-Message-State: AOJu0YxsbZz0R5+Z/ScbEtB0d2PmIN91jx0FnkaNYNrl1rm2hhZY4JLo A30Kv9LV3NU5bFV19u8rVBdshDyYpXNB3+t2F08Sv+GolZFJg0oXpUBOJSGm+oU= X-Gm-Gg: ASbGncstPwNf5AiuN1uGBeD984rvBCnKKmM6tJVuI6gdLkjMLem3DYuFFKZbSFHVgRy /uI9zEstwWNvH184hSBTIERn8PnMPJZ5XdgLUkIID4hVPFDpoHcyfi3aoWOmfbxw+fXqiZhJyJa i5Na7juflVDMZDhBS5torIdIpMJO7Tf6PyIe7ir3F69taah8cnWUoSBM21wwYyEpqlbRIoety9m e+ddP0ags5izQ9SMNGLaRInUjWGlnbNNeDLrX7XQvWI8rmBDBQXHtlJ1M+KoK3bMvr286NfpDUT hxvmfAUkNJx2h0ZN37zwnuteo04rArHT9zERcYAcfyKu1TY= X-Google-Smtp-Source: AGHT+IFHGSYkE2gK8J+M4s6UHrhYt2yFRPQZ8hFQm3oPTcuYK/Fs6x7qFNLpzA/inMpx9KuBn36otA== X-Received: by 2002:a17:903:41c3:b0:216:61d2:46b8 with SMTP id d9443c01a7336-21c3555eb72mr575490595ad.23.1737923894867; Sun, 26 Jan 2025 12:38:14 -0800 (PST) Received: from [192.168.0.4] (174-21-71-127.tukw.qwest.net. [174.21.71.127]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da3d9b8e0sm50214325ad.40.2025.01.26.12.38.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jan 2025 12:38:14 -0800 (PST) Message-ID: <36f6337f-f076-44df-bbb0-29290a010b1a@linaro.org> Date: Sun, 26 Jan 2025 12:38:12 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/20] accel/tcg: Rename 'hw/core/tcg-cpu-ops.h' -> 'accel/tcg/cpu-ops.h' From: Richard Henderson To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini , qemu-arm@nongnu.org, Igor Mammedov , =?UTF-8?Q?Alex_Benn=C3=A9e?= , kvm@vger.kernel.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, David Hildenbrand , qemu-s390x@nongnu.org, xen-devel@lists.xenproject.org References: <20250123234415.59850-1-philmd@linaro.org> <20250123234415.59850-11-philmd@linaro.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/26/25 12:36, Richard Henderson wrote: > On 1/23/25 15:44, Philippe Mathieu-Daudé wrote: >> TCGCPUOps structure makes more sense in the accelerator context >> rather than hardware emulation. Move it under the accel/tcg/ scope. >> >> Mechanical change doing: >> >>   $  sed -i -e 's,hw/core/tcg-cpu-ops.h,accel/tcg/cpu-ops.h,g' \ >>     $(git grep -l hw/core/tcg-cpu-ops.h) >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   MAINTAINERS                                            | 2 +- >>   include/{hw/core/tcg-cpu-ops.h => accel/tcg/cpu-ops.h} | 0 >>   accel/tcg/cpu-exec.c                                   | 4 ++-- >>   accel/tcg/cputlb.c                                     | 2 +- >>   accel/tcg/translate-all.c                              | 2 +- >>   accel/tcg/user-exec.c                                  | 2 +- >>   accel/tcg/watchpoint.c                                 | 2 +- >>   bsd-user/signal.c                                      | 2 +- >>   hw/mips/jazz.c                                         | 2 +- >>   linux-user/signal.c                                    | 2 +- >>   system/physmem.c                                       | 2 +- >>   target/alpha/cpu.c                                     | 2 +- >>   target/arm/cpu.c                                       | 2 +- >>   target/arm/tcg/cpu-v7m.c                               | 2 +- >>   target/arm/tcg/cpu32.c                                 | 2 +- >>   target/arm/tcg/mte_helper.c                            | 2 +- >>   target/arm/tcg/sve_helper.c                            | 2 +- >>   target/avr/cpu.c                                       | 2 +- >>   target/avr/helper.c                                    | 2 +- >>   target/hexagon/cpu.c                                   | 2 +- >>   target/hppa/cpu.c                                      | 2 +- >>   target/i386/tcg/tcg-cpu.c                              | 2 +- >>   target/loongarch/cpu.c                                 | 2 +- >>   target/m68k/cpu.c                                      | 2 +- >>   target/microblaze/cpu.c                                | 2 +- >>   target/mips/cpu.c                                      | 2 +- >>   target/openrisc/cpu.c                                  | 2 +- >>   target/ppc/cpu_init.c                                  | 2 +- >>   target/riscv/tcg/tcg-cpu.c                             | 2 +- >>   target/rx/cpu.c                                        | 2 +- >>   target/s390x/cpu.c                                     | 2 +- >>   target/s390x/tcg/mem_helper.c                          | 2 +- >>   target/sh4/cpu.c                                       | 2 +- >>   target/sparc/cpu.c                                     | 2 +- >>   target/tricore/cpu.c                                   | 2 +- >>   target/xtensa/cpu.c                                    | 2 +- >>   36 files changed, 36 insertions(+), 36 deletions(-) >>   rename include/{hw/core/tcg-cpu-ops.h => accel/tcg/cpu-ops.h} (100%) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 7be3d8f431a..fa46d077d30 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -175,7 +175,7 @@ F: include/exec/helper-info.c.inc >>   F: include/exec/page-protection.h >>   F: include/system/cpus.h >>   F: include/system/tcg.h >> -F: include/hw/core/tcg-cpu-ops.h >> +F: include/accel/tcg/cpu-ops.h >>   F: host/include/*/host/cpuinfo.h >>   F: util/cpuinfo-*.c >>   F: include/tcg/ >> diff --git a/include/hw/core/tcg-cpu-ops.h b/include/accel/tcg/cpu-ops.h >> similarity index 100% >> rename from include/hw/core/tcg-cpu-ops.h >> rename to include/accel/tcg/cpu-ops.h >> diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c >> index be2ba199d3d..8ee76e14b0d 100644 >> --- a/accel/tcg/cpu-exec.c >> +++ b/accel/tcg/cpu-exec.c >> @@ -22,7 +22,7 @@ >>   #include "qapi/error.h" >>   #include "qapi/type-helpers.h" >>   #include "hw/core/cpu.h" >> -#include "hw/core/tcg-cpu-ops.h" >> +#include "accel/tcg/cpu-ops.h" >>   #include "trace.h" >>   #include "disas/disas.h" >>   #include "exec/cpu-common.h" >> @@ -39,7 +39,7 @@ >>   #include "exec/replay-core.h" >>   #include "system/tcg.h" >>   #include "exec/helper-proto-common.h" >> -#include "tb-jmp-cache.h" >> +//#include "tb-jmp-cache.h" > > What's this? Aside from this, Reviewed-by: Richard Henderson r~