From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Taylor Simpson <ltaylorsimpson@gmail.com>, qemu-devel@nongnu.org
Cc: bcain@quicinc.com, quic_mathbern@quicinc.com,
sidneym@quicinc.com, quic_mliebel@quicinc.com,
richard.henderson@linaro.org, ale@rev.ng, anjo@rev.ng
Subject: Re: [PATCH] Hexagon (target/hexagon) Fix shadow variable when idef-parser is off
Date: Thu, 30 Nov 2023 21:16:53 +0100 [thread overview]
Message-ID: <36fe2c1d-4db6-498e-a7ce-da74410b4a03@linaro.org> (raw)
In-Reply-To: <20231130183955.54314-1-ltaylorsimpson@gmail.com>
On 30/11/23 19:39, Taylor Simpson wrote:
> Adding -Werror=shadow=compatible-local causes Hexagon not to build
> when idef-parser is off. The "label" variable in CHECK_NOSHUF_PRED
> shadows a variable in the surrounding code.
>
> Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
> ---
> target/hexagon/macros.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h
> index 9a51b5709b..f99390e2a8 100644
> --- a/target/hexagon/macros.h
> +++ b/target/hexagon/macros.h
> @@ -93,13 +93,13 @@
>
> #define CHECK_NOSHUF_PRED(GET_EA, SIZE, PRED) \
> do { \
> - TCGLabel *label = gen_new_label(); \
> - tcg_gen_brcondi_tl(TCG_COND_EQ, PRED, 0, label); \
> + TCGLabel *noshuf_label = gen_new_label(); \
> + tcg_gen_brcondi_tl(TCG_COND_EQ, PRED, 0, noshuf_label); \
Fragile, but sufficient.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-11-30 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 18:39 [PATCH] Hexagon (target/hexagon) Fix shadow variable when idef-parser is off Taylor Simpson
2023-11-30 19:33 ` Brian Cain
2023-11-30 20:16 ` Philippe Mathieu-Daudé [this message]
2023-11-30 20:39 ` Brian Cain
2023-12-01 10:50 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36fe2c1d-4db6-498e-a7ce-da74410b4a03@linaro.org \
--to=philmd@linaro.org \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=ltaylorsimpson@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=quic_mliebel@quicinc.com \
--cc=richard.henderson@linaro.org \
--cc=sidneym@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).