From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: qemu-devel <qemu-devel@nongnu.org>, hreitz@redhat.com
Cc: qemu-s390x <qemu-s390x@nongnu.org>,
Thomas Huth <thuth@redhat.com>, Cornelia Huck <cohuck@redhat.com>,
David Hildenbrand <david@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Ilya Leoshkevich <iii@linux.ibm.com>,
kwolf@redhat.com, qemu-block@nongnu.org
Subject: Re: [PATCH 1/1] qemu-iotests/stream-under-throttle: do not shutdown QEMU
Date: Mon, 12 Dec 2022 11:13:13 +0100 [thread overview]
Message-ID: <3701fed1-b57a-185b-d848-65605cb09ddb@linux.ibm.com> (raw)
In-Reply-To: <20221207131452.8455-1-borntraeger@linux.ibm.com>
Am 07.12.22 um 14:14 schrieb Christian Borntraeger:
> Without a kernel or boot disk a QEMU on s390 will exit (usually with a
> disabled wait state). This breaks the stream-under-throttle test case.
> Do not exit qemu if on s390.
>
> Signed-off-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> ---
> tests/qemu-iotests/tests/stream-under-throttle | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qemu-iotests/tests/stream-under-throttle b/tests/qemu-iotests/tests/stream-under-throttle
> index 8d2d9e16840d..c24dfbcaa2f2 100755
> --- a/tests/qemu-iotests/tests/stream-under-throttle
> +++ b/tests/qemu-iotests/tests/stream-under-throttle
> @@ -88,6 +88,8 @@ class TestStreamWithThrottle(iotests.QMPTestCase):
> 'x-iops-total=10000,x-bps-total=104857600')
> self.vm.add_blockdev(self.vm.qmp_to_opts(blockdev))
> self.vm.add_device('virtio-blk,iothread=iothr0,drive=throttled-node')
> + if iotests.qemu_default_machine == 's390-ccw-virtio':
> + self.vm.add_args('-no-shutdown')
> self.vm.launch()
>
> def tearDown(self) -> None:
ping. I guess, this will come after the release?
next prev parent reply other threads:[~2022-12-12 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 13:14 [PATCH 1/1] qemu-iotests/stream-under-throttle: do not shutdown QEMU Christian Borntraeger
2022-12-07 13:23 ` Thomas Huth
2022-12-07 14:07 ` Christian Borntraeger
2022-12-12 10:13 ` Christian Borntraeger [this message]
2023-01-04 10:10 ` Thomas Huth
2023-01-10 13:21 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3701fed1-b57a-185b-d848-65605cb09ddb@linux.ibm.com \
--to=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=hreitz@redhat.com \
--cc=iii@linux.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).