From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Sven Schnelle" <svens@stackframe.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Helge Deller <deller@gmx.de>,
qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v5 5/6] hppa: Add emulation of Artist graphics
Date: Tue, 24 Dec 2019 01:18:33 +0100 [thread overview]
Message-ID: <37033554-7247-8301-a527-c48f6d74b91a@redhat.com> (raw)
In-Reply-To: <20191223175006.GA17323@t470p.stackframe.org>
On 12/23/19 6:50 PM, Sven Schnelle wrote:
> Hi Philippe,
>
> On Sun, Dec 22, 2019 at 01:37:48PM +0100, Philippe Mathieu-Daudé wrote:
>>>
>>> + if (vga_interface_type != VGA_NONE) {
>>> + dev = qdev_create(NULL, "artist");
>>> + qdev_init_nofail(dev);
>>> + s = SYS_BUS_DEVICE(dev);
>>> + sysbus_mmio_map(s, 0, LASI_GFX_HPA);
>>> + sysbus_mmio_map(s, 1, ARTIST_FB_ADDR);
>>
>> How is this chipset connected on the board?
>> If it is a card you can plug on a bus, you can use a condition.
>> If it is soldered or part of another chipset, then it has to be mapped
>> unconditionally.
>
> Depends on the Model. Hp 9000 712 and 715 had it onboard, for the B160L
> we're emulating and others it was a GSC add-on card.
The B160L case is unclear, do you mean this is not the chipset on the
machine, but the software is happy if another chipset is available?
Looking at hw/hppa/ I only see one machine:
static void machine_hppa_machine_init(MachineClass *mc)
{
mc->desc = "HPPA generic machine";
...
}
DEFINE_MACHINE("hppa", machine_hppa_machine_init)
Are you saying this generic machine is able to run different physical
hw? Why not add them? This shouldn't take long and it would be clearer,
what do you think?
Adding different machines here in QEMU mostly mean add a class which
declare the different properties used by each machine. Igor Mammedov
recently suggested to follow the example of aspeed_machine_types[] in
hw/arm/aspeed.c.
next prev parent reply other threads:[~2019-12-24 0:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 21:15 [PATCH v5 0/6] HPPA: i82596, PS/2 and graphics emulation Sven Schnelle
2019-12-20 21:15 ` [PATCH v5 1/6] hw/hppa/dino.c: Improve emulation of Dino PCI chip Sven Schnelle
2020-02-12 23:37 ` Philippe Mathieu-Daudé
2020-02-13 22:59 ` Philippe Mathieu-Daudé
2019-12-20 21:15 ` [PATCH v5 2/6] hppa: Add support for LASI chip with i82596 NIC Sven Schnelle
2019-12-20 21:15 ` [PATCH v5 3/6] ps2: accept 'Set Key Make and Break' commands Sven Schnelle
2019-12-20 21:15 ` [PATCH v5 4/6] hppa: add emulation of LASI PS2 controllers Sven Schnelle
2020-01-03 6:15 ` Philippe Mathieu-Daudé
2020-01-19 17:22 ` Sven Schnelle
2019-12-20 21:15 ` [PATCH v5 5/6] hppa: Add emulation of Artist graphics Sven Schnelle
2019-12-22 12:37 ` Philippe Mathieu-Daudé
2019-12-23 17:50 ` Sven Schnelle
2019-12-24 0:18 ` Philippe Mathieu-Daudé [this message]
2019-12-27 20:57 ` Helge Deller
2019-12-29 23:15 ` Philippe Mathieu-Daudé
2020-02-12 23:55 ` Philippe Mathieu-Daudé
2019-12-20 21:15 ` [PATCH v5 6/6] seabios-hppa: update to latest version Sven Schnelle
2019-12-22 12:33 ` Philippe Mathieu-Daudé
2019-12-21 22:22 ` [PATCH v5 0/6] HPPA: i82596, PS/2 and graphics emulation Helge Deller
2019-12-21 22:24 ` [PATCH 1/2] hppa: Do not enable artist graphics with -nographic option Helge Deller
2019-12-22 8:39 ` Sven Schnelle
2019-12-22 10:22 ` Helge Deller
2019-12-29 1:25 ` Richard Henderson
2019-12-21 22:25 ` [PATCH 2/2] hppa: Switch to tulip NIC by default Helge Deller
2019-12-29 1:25 ` Richard Henderson
2019-12-29 1:25 ` [PATCH v5 0/6] HPPA: i82596, PS/2 and graphics emulation Richard Henderson
2019-12-29 13:08 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37033554-7247-8301-a527-c48f6d74b91a@redhat.com \
--to=philmd@redhat.com \
--cc=deller@gmx.de \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).