From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.1 required=3.0 tests=BAYES_00, CHARSET_FARAWAY_HEADER,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 173D2C433E2 for ; Wed, 2 Sep 2020 05:03:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8EB420709 for ; Wed, 2 Sep 2020 05:03:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=tencent.com header.i=@tencent.com header.b="DCyUCRuh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8EB420709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=tencent.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDKvk-0006L7-VB for qemu-devel@archiver.kernel.org; Wed, 02 Sep 2020 01:03:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDJ4y-0004NJ-FT for qemu-devel@nongnu.org; Tue, 01 Sep 2020 23:04:56 -0400 Received: from mail6.tencent.com ([220.249.245.26]:58002) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDJ4n-0004lR-JI for qemu-devel@nongnu.org; Tue, 01 Sep 2020 23:04:49 -0400 Received: from EX-SZ020.tencent.com (unknown [10.28.6.40]) by mail6.tencent.com (Postfix) with ESMTP id D42E4CC3CC; Wed, 2 Sep 2020 11:05:43 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tencent.com; s=s202002; t=1599015943; bh=prgWJHQiDmmzGESHWoloTU8GlwJvf5H+oCzw3K9vBsM=; h=From:To:CC:Subject:Date; b=DCyUCRuhHJHzmNEwwJJwKhcOhNMqGFzYwEcjfwboQHxldmNVchAKEs9ZR87iddj9/ 1UBvZeENbV4QART1YULA0Ml+1/760CxeVxFpv7MuFDCjSqshdB0LE8WKXUaEHx7Vlv RDDJFwN4r7QAODDCrs957dyp6sQQ4X6mowGEx+c4= Received: from EX-SZ001.tencent.com (10.28.6.13) by EX-SZ020.tencent.com (10.28.6.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Wed, 2 Sep 2020 11:04:24 +0800 Received: from EX-SZ007.tencent.com (10.28.6.31) by EX-SZ001.tencent.com (10.28.6.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Wed, 2 Sep 2020 11:04:24 +0800 Received: from EX-SZ007.tencent.com ([fe80::c18:7c89:3e4e:3c42]) by EX-SZ007.tencent.com ([fe80::c18:7c89:3e4e:3c42%8]) with mapi id 15.01.1847.007; Wed, 2 Sep 2020 11:04:24 +0800 From: =?gb2312?B?cnVpcHBhbijFy+6jKQ==?= To: "kraxel@redhat.com" Subject: ui: fix potential compile error. Thread-Topic: ui: fix potential compile error. Thread-Index: AdaA1cIX+J3VvXsaQtu3KAdRudKiUg== Date: Wed, 2 Sep 2020 03:04:24 +0000 Message-ID: <370e6ed66acf43e68f1ef2bffc3026f7@tencent.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.28.2.34] Content-Type: multipart/mixed; boundary="_004_370e6ed66acf43e68f1ef2bffc3026f7tencentcom_" MIME-Version: 1.0 Received-SPF: pass client-ip=220.249.245.26; envelope-from=ruippan@tencent.com; helo=mail6.tencent.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 23:04:25 X-ACL-Warn: Detected OS = Linux 3.1-3.10 X-Spam_score_int: 36 X-Spam_score: 3.6 X-Spam_bar: +++ X-Spam_report: (3.6 / 5.0 requ) BAYES_00=-1.9, CHARSET_FARAWAY_HEADER=3.2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MIME_CHARSET_FARAWAY=2.45, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 02 Sep 2020 01:02:30 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-devel@nongnu.org" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --_004_370e6ed66acf43e68f1ef2bffc3026f7tencentcom_ Content-Type: multipart/alternative; boundary="_000_370e6ed66acf43e68f1ef2bffc3026f7tencentcom_" --_000_370e6ed66acf43e68f1ef2bffc3026f7tencentcom_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 V2UgY29tcGlsZWQgdGhlIHVwc3RyZWFtIHFlbXUgYW5kIHJlc3VsdCBpbiB0aGlzIEdFTiBjb2Rl IGVycm9yOg0KDQqhrqGvoa8NCkdFTiAgICAgdWkvaW5wdXQta2V5bWFwLWF0c2V0MS10by1xY29k ZS5jDQp1c2FnZToga2V5bWFwLWdlbiBbLWhdDQogICAgICAgICAgICAgICAgICB7Y29kZS1tYXAs Y29kZS10YWJsZSxuYW1lLW1hcCxuYW1lLXRhYmxlLGNvZGUtZG9jcyxuYW1lLWRvY3N9DQogICAg ICAgICAgICAgICAgICAuLi4NCmtleW1hcC1nZW46IGVycm9yOiBpbnZhbGlkIGNob2ljZTogJ2ds aWIyJyAoY2hvb3NlIGZyb20gJ2NvZGUtbWFwJywgJ2NvZGUtdGFibGUnLCAnbmFtZS1tYXAnLCAn bmFtZS10YWJsZScsICdjb2RlLWRvY3MnLCAnbmFtZS1kb2NzJykNCqGuoa+hrw0KDQpNeSBlbnZp cm9ubWVudDoNCg0KMS4gICAgIENlbnRPUzcgd2l0aCBQeXRob24gMi43LjUNCg0KMi4gICAgIHVw c3RyZWFtJ3Mga2V5Y29kZW1hcGRiDQoNCjMuICAgICBhcmdwYXJzZSAxLjENCg0KUm9vdCBjYXVz ZSBpcyBteSBhcmdwYXJzZSBhbmQgcHl0aG9uIHZlcnNpb24uIEJ1dCBjaGFuZ2UgdGhlIGludm9r aW5nIG9yZGVyIGNhbiBhZGFwdCBib3RoIG5ldyBhbmQgb2xkIGFyZ3BhcnNlLg0KDQpUaGFua3Mu DQo= --_000_370e6ed66acf43e68f1ef2bffc3026f7tencentcom_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

We compiled the upstream qemu a= nd result in this GEN code error:

 

=A1=AE=A1= =AF=A1=AF

GEN &n= bsp;   ui/input-keymap-atset1-to-qcode.c

usage: keym= ap-gen [-h]

  = ;            &n= bsp;   {code-map,code-table,name-map,name-table,code-docs,name-do= cs}

  = ;            &n= bsp;   ...

keymap-gen:= error: invalid choice: 'glib2' (choose from 'code-map', 'code-table', 'nam= e-map', 'name-table', 'code-docs', 'name-docs')

=A1=AE=A1= =AF=A1=AF

 

My environment:

1= .   &= nbsp; CentOS7 with Python 2.7= .5

2= .   &= nbsp; upstream's keycodemapdb=

3= .   &= nbsp; argparse 1.1=

 

Root cause is my argparse and p= ython version. But change the invoking order can adapt both new and old arg= parse.

 

Thanks.

--_000_370e6ed66acf43e68f1ef2bffc3026f7tencentcom_-- --_004_370e6ed66acf43e68f1ef2bffc3026f7tencentcom_ Content-Type: application/octet-stream; name="0001-ui-fix-potential-compile-error.patch" Content-Description: 0001-ui-fix-potential-compile-error.patch Content-Disposition: attachment; filename="0001-ui-fix-potential-compile-error.patch"; size=1350; creation-date="Wed, 02 Sep 2020 02:54:37 GMT"; modification-date="Wed, 02 Sep 2020 02:51:22 GMT" Content-Transfer-Encoding: base64 RnJvbSA3ZjI2MmIxNjBkNTc1NTliYWNlMWY4NzdmNzRiMWM0ZTVhODcyYjQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBydWlwcGFuIDxydWlwcGFuQHRlbmNlbnQuY29tPgpEYXRlOiBX ZWQsIDIgU2VwIDIwMjAgMTA6NDA6MjkgKzA4MDAKU3ViamVjdDogW1BBVENIXSB1aTogZml4IHBv dGVudGlhbCBjb21waWxlIGVycm9yLgoKRml4IGNvZGUgR0VOIGVycm9yIHdpdGggaW5mbyAia2V5 bWFwLWdlbjogZXJyb3I6IGludmFsaWQgY2hvaWNlOiAnZ2xpYjInIi4KQ29tcGlsZSBlbnZpcm9u bWVudDoKMS4gQ2VudE9TNyB3aXRoIFB5dGhvbiAyLjcuNQoyLiB1cHN0cmVhbSdzIGtleWNvZGVt YXBkYgozLiBhcmdwYXJzZSAxLjEKCkNoYW5nZSBhcmcgb3JkZXIgdG8gYWRhcHQgb2xkIHZlcnNp b24gb2YgYXJncGFyc2UuCgpTaWduZWQtb2ZmLWJ5OiBydWlwcGFuIDxydWlwcGFuQHRlbmNlbnQu Y29tPgotLS0KIHVpL21lc29uLmJ1aWxkIHwgNiArKystLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvdWkvbWVzb24uYnVpbGQg Yi91aS9tZXNvbi5idWlsZAppbmRleCA5NjJlNzc2NTY5Li40N2UxMzk5MDNiIDEwMDY0NAotLS0g YS91aS9tZXNvbi5idWlsZAorKysgYi91aS9tZXNvbi5idWlsZApAQCAtMTA1LDkgKzEwNSw5IEBA IGlmIGhhdmVfc3lzdGVtIG9yIHhrYmNvbW1vbi5mb3VuZCgpCiAgICAgICAgICAgICAgICAgICBj YXB0dXJlOiB0cnVlLAogICAgICAgICAgICAgICAgICAgaW5wdXQ6IGZpbGVzKCdrZXljb2RlbWFw ZGIvZGF0YS9rZXltYXBzLmNzdicpLAogICAgICAgICAgICAgICAgICAgY29tbWFuZDogW3B5dGhv bi5mdWxsX3BhdGgoKSwgZmlsZXMoJ2tleWNvZGVtYXBkYi90b29scy9rZXltYXAtZ2VuJyksCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgJy0tbGFuZycsICdnbGliMicsCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgJy0tdmFybmFtZScsICdxZW11X2lucHV0X21hcF9AMEBfdG9fQDFA Jy5mb3JtYXQoZVswXSwgZVsxXSksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2NvZGUt bWFwJywgJ0BJTlBVVDBAJywgZVswXSwgZVsxXV0pCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAnY29kZS1tYXAnLCAnQElOUFVUMEAnLCBlWzBdLCBlWzFdLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgJy0tbGFuZycsICdnbGliMicsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAn LS12YXJuYW1lJywgJ3FlbXVfaW5wdXRfbWFwX0AwQF90b19AMUAnLmZvcm1hdChlWzBdLCBlWzFd KV0pCiAgIGVuZGZvcmVhY2gKIGVuZGlmCiAKLS0gCjIuMTkuMQoK --_004_370e6ed66acf43e68f1ef2bffc3026f7tencentcom_--