From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D703C02194 for ; Thu, 6 Feb 2025 09:28:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tfyAi-0007KY-5I; Thu, 06 Feb 2025 04:27:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tfyAg-0007JY-Dq for qemu-devel@nongnu.org; Thu, 06 Feb 2025 04:27:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tfyAe-0004Te-CF for qemu-devel@nongnu.org; Thu, 06 Feb 2025 04:27:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738834059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Kraiodq5yodhpoLdZHjfkXkvAzl7YznfAux4sffab/k=; b=RU9cxX1VkrVpp6ZthP2yq892nXIt83mK0iOeuNjJOal5QTrxwT8DOs6NbWiLVkYm2up95q jqhxsgaTSKD62GNmU0G7tATrxULnQmbpJK1rUx/gzcAn3VQWjmCXHW8FBZFh0YJLonGHds DJjsP1N18eDyScKtA2t33CvFqqDjB2w= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-60-MnLTds7WNfKNLQ2TJUosuQ-1; Thu, 06 Feb 2025 04:27:37 -0500 X-MC-Unique: MnLTds7WNfKNLQ2TJUosuQ-1 X-Mimecast-MFC-AGG-ID: MnLTds7WNfKNLQ2TJUosuQ Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4361efc9dc6so3936095e9.3 for ; Thu, 06 Feb 2025 01:27:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738834056; x=1739438856; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Kraiodq5yodhpoLdZHjfkXkvAzl7YznfAux4sffab/k=; b=eAbb5V3WYaOoU6YgQqrlX8Ixdi7iPOP01kqTqN4IunuwqK4c4hj15Vrln686fUjcAS AWUYkb9+HjK4GPjeohlSLoWLaGTw+JW8h2mHDvLEVLAdgsjSaXZLZvAwEHX1PMw97KOW lDMO1dso9ccP0x6Lfc1NHiJDfcS0TK66yFAl4v5tA2CfbAUjbHu5YNClxtwNe3o17LdZ 3XE9hkkZV03jkBVLFcLhE2vRndxu3S20ewn+A37dDtevObujFx5BSyHum7dVx6CXQZ6V 87/4WVibOdfLx9ifJHko4ZwQiHC7rkwwKjBKyw0gjmrCqi+ph1Nc7xBaum4dVnvi7x8K 9bWg== X-Forwarded-Encrypted: i=1; AJvYcCVg5ExoDqB6uIhRqTYVDFHeF8U3NTfompBJ8VjBXRapVyfy4xdIf4jpcVDor9VdVq2j8cyPHwfPFC5w@nongnu.org X-Gm-Message-State: AOJu0Ywq4yqWzNQAf47gcKS+F4hxuOAv+kEBlEOdV6DqUcgzXljozrPR /OwqFrpzvOf4I27n8/Zb32peqr5wDTrQIllZqpfjLjpyxJlIGb4Ylojcg06VYOHgfkR/57xRpXr /o9s891lnmKh7AYVTqJqX3aJZCheeqPFPE/jPihJrVu8dGPX0xtgo X-Gm-Gg: ASbGnct6XVDvnx1Skh+c6Nr9swdKcDZ+ABAFriJ4TaB0DMmJtBj+NQx6rrmHUyPExDq Gu5JuS5kJ/TGPEvY5wgnwQBsHd8tBRKBREkx4FKdVJoG4M804SX3MoobJhH9xTUONuj0R14Ksin NuFi2lXMBQLvQU8xpjFgzodSJAWgC9zcDGutFtgyH2ljXLCs5FjEFHRSP3dNwCMps9xeK8a9IGt ebQ5UEaUcdAVSh3aaOWZRvp1p0kDA93WEAP9a7nt9z8uMLG8DbPvwIVbyazAMlU/phuS8YAcGLD xDiNgh9zF9nkJNecoxQtcwdSWTD46HuFVN9R X-Received: by 2002:a05:600c:46c9:b0:434:e8cf:6390 with SMTP id 5b1f17b1804b1-4390d42ce2bmr45913805e9.6.1738834056222; Thu, 06 Feb 2025 01:27:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGtRswpHQWTFBCljDoM7AJTYEa45eaqkX5V4jufPhGMn9XTilcvvvMEIWtm99NfGNhaespP+g== X-Received: by 2002:a05:600c:46c9:b0:434:e8cf:6390 with SMTP id 5b1f17b1804b1-4390d42ce2bmr45913625e9.6.1738834055824; Thu, 06 Feb 2025 01:27:35 -0800 (PST) Received: from [192.168.0.7] (ip-109-42-48-132.web.vodafone.de. [109.42.48.132]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dbde0fc1asm1222832f8f.67.2025.02.06.01.27.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2025 01:27:35 -0800 (PST) Message-ID: <370f5393-e19e-4dfd-a627-05a60ba80bbb@redhat.com> Date: Thu, 6 Feb 2025 10:27:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] tests/functional: remove all class level fields To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= References: <20250205155946.2811296-1-berrange@redhat.com> <20250205155946.2811296-5-berrange@redhat.com> Content-Language: en-US From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250205155946.2811296-5-berrange@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 05/02/2025 16.59, Daniel P. Berrangé wrote: > A number of fields are set at the class level on QemuBaseTest, even > though the exact same named field is then set at the object level > later in most cases. > > Signed-off-by: Daniel P. Berrangé > --- > tests/functional/qemu_test/testcase.py | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py > index 574c1942f2..531d6393ad 100644 > --- a/tests/functional/qemu_test/testcase.py > +++ b/tests/functional/qemu_test/testcase.py > @@ -33,12 +33,6 @@ > > class QemuBaseTest(unittest.TestCase): > > - arch = None > - > - workdir = None > - log = None > - logdir = None That's what you get when a Python ignorant like me tries to write object oriented Python code ;-) Thanks for cleaning up my mess! Reviewed-by: Thomas Huth