From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: "Eric Blake" <eblake@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] configure: Remove spurious [] from tr
Date: Thu, 12 Aug 2021 19:51:24 +0200 [thread overview]
Message-ID: <3712b78c-063d-803c-004f-ed7544ee0d19@redhat.com> (raw)
In-Reply-To: <YRUcoAiKWtxfPVqB@work-vm>
On 12/08/21 15:05, Dr. David Alan Gilbert wrote:
> In configure line 4464:
> if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then
> ^-- SC1035: You are missing a required space after the !.
>
> which hmm I've not quite got my head around yet; but maybe that one is
> real.
Trying
! (echo abc); echo $?
!(echo abc); echo $?
both work in bash, but the latter fails with zsh:
abc
1
ff:2: no matches found: !(echo abc)
Paolo
next prev parent reply other threads:[~2021-08-12 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 11:09 [PATCH] configure: Remove spurious [] from tr Dr. David Alan Gilbert (git)
2021-08-12 11:58 ` Peter Maydell
2021-08-12 13:05 ` Dr. David Alan Gilbert
2021-08-12 13:54 ` Eric Blake
2021-08-12 17:51 ` Paolo Bonzini [this message]
2021-08-12 17:49 ` Paolo Bonzini
2021-08-12 17:54 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3712b78c-063d-803c-004f-ed7544ee0d19@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).