From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehJIc-0005LF-7P for qemu-devel@nongnu.org; Thu, 01 Feb 2018 13:09:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehJIb-0002gt-En for qemu-devel@nongnu.org; Thu, 01 Feb 2018 13:09:26 -0500 References: <4361f774-7d2e-1a67-bde9-da421df554f9@redhat.com> From: Max Reitz Message-ID: <372299e3-6efe-aa6c-85ae-ccb26e1c6f3e@redhat.com> Date: Thu, 1 Feb 2018 19:09:09 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="my0sKQG71G0tWZKR6vb3N6MdyQ0Iwn4p5" Subject: Re: [Qemu-devel] [PATCH v3 13/39] qcow2: Add l2_slice_size field to BDRVQcow2State List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Eric Blake , Anton Nefedov , "Denis V . Lunev" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --my0sKQG71G0tWZKR6vb3N6MdyQ0Iwn4p5 From: Max Reitz To: Alberto Garcia , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Eric Blake , Anton Nefedov , "Denis V . Lunev" Message-ID: <372299e3-6efe-aa6c-85ae-ccb26e1c6f3e@redhat.com> Subject: Re: [PATCH v3 13/39] qcow2: Add l2_slice_size field to BDRVQcow2State References: <4361f774-7d2e-1a67-bde9-da421df554f9@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2018-02-01 10:51, Alberto Garcia wrote: > On Wed 31 Jan 2018 08:48:08 PM CET, Max Reitz wrote: >> On 2018-01-26 15:59, Alberto Garcia wrote: >>> The BDRVQcow2State structure contains an l2_size field, which stores >>> the number of 64-bit entries in an L2 table. >>> >>> For efficiency reasons we want to be able to load slices instead of >>> full L2 tables, so we need to know how many entries an L2 slice can >>> hold. >>> >>> An L2 slice is the portion of an L2 table that is loaded by the qcow2= >>> cache. At the moment that cache can only load complete tables, >>> therefore an L2 slice has the same size as an L2 table (one cluster) >>> and l2_size =3D=3D l2_slice_size. >>> >>> Later we'll allow smaller slices, but until then we have to use this >>> new l2_slice_size field to make the rest of the code ready for that. >>> >>> Signed-off-by: Alberto Garcia >>> Reviewed-by: Eric Blake >>> --- >>> block/qcow2.c | 3 +++ >>> block/qcow2.h | 1 + >>> 2 files changed, 4 insertions(+) >> >> Am I missing something or does this patch miss setting l2_slice_size >> in qcow2_do_open()? >=20 > qcow2_do_open() calls qcow2_update_options() which is what reads > l2-cache-entry-size and sets s->l2_slice_size. So I was missing something, good. Reviewed-by: Max Reitz --my0sKQG71G0tWZKR6vb3N6MdyQ0Iwn4p5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFGBAEBCAAwFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAlpzV8USHG1yZWl0ekBy ZWRoYXQuY29tAAoJEPQH2wBh1c9AgPEH/iWA2sXzrUP70gHfZQmCimrLoz+FgJcn /yidYtJ3WmkMM43x8YHqfmZLWmq3OSgV1qYSSiMhd4MO+b6rrmByBUq68Zi99JT9 6GPJTcKQgybzQUtoyE6HjDaQYHAjGPN0bKGC7GQVlEhYE0O9+f5QkBQ5dY/qQtKk 0CNs73qNPLic5uC2s0I6QtkXpVCR+kAYg/or75J9oU2WeQZAY9Mh/QWDk3u+Axza 8f8xqnnTFxr/+9DNhx1UUCCbXU9Bol08/VweJ566129WWAIHQlxjGeBVhE/KHZN8 EkaQdkKCO/0JiCyAMaaYo2PjhmvTbivmTbWG0LgByl0AdOlNGiEKlPo= =cbUe -----END PGP SIGNATURE----- --my0sKQG71G0tWZKR6vb3N6MdyQ0Iwn4p5--