* [Qemu-devel] [PATCH] fw_cfg: Make base type "fw_cfg" abstract
@ 2016-07-29 7:29 Markus Armbruster
2016-07-29 8:08 ` Laszlo Ersek
0 siblings, 1 reply; 4+ messages in thread
From: Markus Armbruster @ 2016-07-29 7:29 UTC (permalink / raw)
To: qemu-devel; +Cc: lersek, somlo, pbonzini
Missed when commit 5712db6 split off "fw_cfg_io" and "fw_cfg_mem".
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/nvram/fw_cfg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 2873030..0ccab2d 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -990,6 +990,7 @@ static void fw_cfg_class_init(ObjectClass *klass, void *data)
static const TypeInfo fw_cfg_info = {
.name = TYPE_FW_CFG,
.parent = TYPE_SYS_BUS_DEVICE,
+ .abstract = true,
.instance_size = sizeof(FWCfgState),
.class_init = fw_cfg_class_init,
};
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] fw_cfg: Make base type "fw_cfg" abstract
2016-07-29 7:29 [Qemu-devel] [PATCH] fw_cfg: Make base type "fw_cfg" abstract Markus Armbruster
@ 2016-07-29 8:08 ` Laszlo Ersek
2016-07-29 8:18 ` Markus Armbruster
2016-08-01 9:52 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: Laszlo Ersek @ 2016-07-29 8:08 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: somlo, pbonzini
On 07/29/16 09:29, Markus Armbruster wrote:
> Missed when commit 5712db6 split off "fw_cfg_io" and "fw_cfg_mem".
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/nvram/fw_cfg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
> index 2873030..0ccab2d 100644
> --- a/hw/nvram/fw_cfg.c
> +++ b/hw/nvram/fw_cfg.c
> @@ -990,6 +990,7 @@ static void fw_cfg_class_init(ObjectClass *klass, void *data)
> static const TypeInfo fw_cfg_info = {
> .name = TYPE_FW_CFG,
> .parent = TYPE_SYS_BUS_DEVICE,
> + .abstract = true,
> .instance_size = sizeof(FWCfgState),
> .class_init = fw_cfg_class_init,
> };
>
Not sure how consistent we try to be about this: should the equal sign
(in the assignment) line up with the other equal signs?
Looking for prior art, I ran
git grep -E 'abstract {2,}= true'
and it returned 27 hits.
Functionally the patch is right, of course. And I think the whitespace
can be adjusted without a repost, if we agree it should be adjusted.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] fw_cfg: Make base type "fw_cfg" abstract
2016-07-29 8:08 ` Laszlo Ersek
@ 2016-07-29 8:18 ` Markus Armbruster
2016-08-01 9:52 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2016-07-29 8:18 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: qemu-devel, pbonzini, somlo
Laszlo Ersek <lersek@redhat.com> writes:
> On 07/29/16 09:29, Markus Armbruster wrote:
>> Missed when commit 5712db6 split off "fw_cfg_io" and "fw_cfg_mem".
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> hw/nvram/fw_cfg.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
>> index 2873030..0ccab2d 100644
>> --- a/hw/nvram/fw_cfg.c
>> +++ b/hw/nvram/fw_cfg.c
>> @@ -990,6 +990,7 @@ static void fw_cfg_class_init(ObjectClass *klass, void *data)
>> static const TypeInfo fw_cfg_info = {
>> .name = TYPE_FW_CFG,
>> .parent = TYPE_SYS_BUS_DEVICE,
>> + .abstract = true,
>> .instance_size = sizeof(FWCfgState),
>> .class_init = fw_cfg_class_init,
>> };
>>
>
> Not sure how consistent we try to be about this: should the equal sign
> (in the assignment) line up with the other equal signs?
>
> Looking for prior art, I ran
>
> git grep -E 'abstract {2,}= true'
>
> and it returned 27 hits.
>
> Functionally the patch is right, of course. And I think the whitespace
> can be adjusted without a repost, if we agree it should be adjusted.
Yes, please.
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> Thanks!
> Laszlo
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] fw_cfg: Make base type "fw_cfg" abstract
2016-07-29 8:08 ` Laszlo Ersek
2016-07-29 8:18 ` Markus Armbruster
@ 2016-08-01 9:52 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2016-08-01 9:52 UTC (permalink / raw)
To: Laszlo Ersek, Markus Armbruster, qemu-devel; +Cc: somlo
On 29/07/2016 10:08, Laszlo Ersek wrote:
> On 07/29/16 09:29, Markus Armbruster wrote:
>> Missed when commit 5712db6 split off "fw_cfg_io" and "fw_cfg_mem".
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> hw/nvram/fw_cfg.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
>> index 2873030..0ccab2d 100644
>> --- a/hw/nvram/fw_cfg.c
>> +++ b/hw/nvram/fw_cfg.c
>> @@ -990,6 +990,7 @@ static void fw_cfg_class_init(ObjectClass *klass, void *data)
>> static const TypeInfo fw_cfg_info = {
>> .name = TYPE_FW_CFG,
>> .parent = TYPE_SYS_BUS_DEVICE,
>> + .abstract = true,
>> .instance_size = sizeof(FWCfgState),
>> .class_init = fw_cfg_class_init,
>> };
>>
>
> Not sure how consistent we try to be about this: should the equal sign
> (in the assignment) line up with the other equal signs?
>
> Looking for prior art, I ran
>
> git grep -E 'abstract {2,}= true'
>
> and it returned 27 hits.
>
> Functionally the patch is right, of course. And I think the whitespace
> can be adjusted without a repost, if we agree it should be adjusted.
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Tweaked and queued, thanks to both.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-01 9:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-29 7:29 [Qemu-devel] [PATCH] fw_cfg: Make base type "fw_cfg" abstract Markus Armbruster
2016-07-29 8:08 ` Laszlo Ersek
2016-07-29 8:18 ` Markus Armbruster
2016-08-01 9:52 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).