From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bU9tT-0001d3-RF for qemu-devel@nongnu.org; Mon, 01 Aug 2016 05:52:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bU9tO-0000o2-Ub for qemu-devel@nongnu.org; Mon, 01 Aug 2016 05:52:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bU9tO-0000np-OS for qemu-devel@nongnu.org; Mon, 01 Aug 2016 05:52:14 -0400 References: <1469777353-9383-1-git-send-email-armbru@redhat.com> <3f7d347b-5400-22db-77bd-202ef9d2fd32@redhat.com> From: Paolo Bonzini Message-ID: <376287f1-9ed5-b8c1-3516-70cb645d6b07@redhat.com> Date: Mon, 1 Aug 2016 11:52:09 +0200 MIME-Version: 1.0 In-Reply-To: <3f7d347b-5400-22db-77bd-202ef9d2fd32@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] fw_cfg: Make base type "fw_cfg" abstract List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , Markus Armbruster , qemu-devel@nongnu.org Cc: somlo@cmu.edu On 29/07/2016 10:08, Laszlo Ersek wrote: > On 07/29/16 09:29, Markus Armbruster wrote: >> Missed when commit 5712db6 split off "fw_cfg_io" and "fw_cfg_mem". >> >> Signed-off-by: Markus Armbruster >> --- >> hw/nvram/fw_cfg.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c >> index 2873030..0ccab2d 100644 >> --- a/hw/nvram/fw_cfg.c >> +++ b/hw/nvram/fw_cfg.c >> @@ -990,6 +990,7 @@ static void fw_cfg_class_init(ObjectClass *klass, void *data) >> static const TypeInfo fw_cfg_info = { >> .name = TYPE_FW_CFG, >> .parent = TYPE_SYS_BUS_DEVICE, >> + .abstract = true, >> .instance_size = sizeof(FWCfgState), >> .class_init = fw_cfg_class_init, >> }; >> > > Not sure how consistent we try to be about this: should the equal sign > (in the assignment) line up with the other equal signs? > > Looking for prior art, I ran > > git grep -E 'abstract {2,}= true' > > and it returned 27 hits. > > Functionally the patch is right, of course. And I think the whitespace > can be adjusted without a repost, if we agree it should be adjusted. > > Reviewed-by: Laszlo Ersek Tweaked and queued, thanks to both. Paolo