From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Chen Qun <kuhn.chenqun@huawei.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
zhang.zhanghailiang@huawei.com, ganqixin@huawei.com,
Euler Robot <euler.robot@huawei.com>
Subject: Re: [PATCH 3/6] util/qemu-timer: fix uninitialized variable warning in timer_mod_anticipate_ns()
Date: Tue, 3 Nov 2020 03:13:35 +0100 [thread overview]
Message-ID: <37670ee4-d758-0da7-5e2d-b3429e856360@redhat.com> (raw)
In-Reply-To: <20201103015228.2250547-4-kuhn.chenqun@huawei.com>
On 11/3/20 2:52 AM, Chen Qun wrote:
> After the WITH_QEMU_LOCK_GUARD macro is added, the compiler cannot identify
> that the statements in the macro must be executed. As a result, some variables
> assignment statements in the macro may be considered as unexecuted by the compiler.
>
> The compiler showed warning:
> util/qemu-timer.c: In function ‘timer_mod_anticipate_ns’:
> util/qemu-timer.c:474:8: warning: ‘rearm’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> 474 | if (rearm) {
> | ^
>
> Change the default value assignment place to prevented the warning.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
> util/qemu-timer.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-11-03 2:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 1:52 [PATCH 0/6] fix uninitialized variable warning Chen Qun
2020-11-03 1:52 ` [PATCH 1/6] target/xtensa: " Chen Qun
2020-11-03 2:27 ` Philippe Mathieu-Daudé
2020-11-03 9:21 ` Max Filippov
2020-11-04 3:03 ` Chenqun (kuhn)
2020-11-03 1:52 ` [PATCH 2/6] hw/rdma/rdma_backend: fix uninitialized variable warning in rdma_poll_cq() Chen Qun
2020-11-03 16:41 ` Marcel Apfelbaum
2020-11-03 19:49 ` Yuval Shaia
2020-11-03 1:52 ` [PATCH 3/6] util/qemu-timer: fix uninitialized variable warning in timer_mod_anticipate_ns() Chen Qun
2020-11-03 2:13 ` Philippe Mathieu-Daudé [this message]
2020-11-03 1:52 ` [PATCH 4/6] util/qemu-timer: fix uninitialized variable warning for expire_time Chen Qun
2020-11-03 1:52 ` [PATCH 5/6] plugins/loader: fix uninitialized variable warning in plugin_reset_uninstall() Chen Qun
2020-11-03 2:18 ` Philippe Mathieu-Daudé
2020-11-03 2:34 ` Chenqun (kuhn)
2020-11-03 1:52 ` [PATCH 6/6] migration: fix uninitialized variable warning in migrate_send_rp_req_pages() Chen Qun
2020-11-03 2:22 ` Philippe Mathieu-Daudé
2020-11-03 10:15 ` [PATCH 0/6] fix uninitialized variable warning Peter Maydell
2020-11-03 10:44 ` Chenqun (kuhn)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37670ee4-d758-0da7-5e2d-b3429e856360@redhat.com \
--to=philmd@redhat.com \
--cc=euler.robot@huawei.com \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).