From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nom2o-0003Rf-8x for qemu-devel@nongnu.org; Mon, 08 Mar 2010 18:07:26 -0500 Received: from [199.232.76.173] (port=50235 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nom2h-0003A2-Ej for qemu-devel@nongnu.org; Mon, 08 Mar 2010 18:07:19 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NolsE-0001h3-1F for qemu-devel@nongnu.org; Mon, 08 Mar 2010 17:56:38 -0500 Received: from mx20.gnu.org ([199.232.41.8]:58616) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nols7-00019N-Ed for qemu-devel@nongnu.org; Mon, 08 Mar 2010 17:56:27 -0500 Received: from smtp-out.google.com ([216.239.44.51]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nolbe-0004Je-Qw for qemu-devel@nongnu.org; Mon, 08 Mar 2010 17:39:23 -0500 Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by smtp-out.google.com with ESMTP id o28McZfb003148 for ; Mon, 8 Mar 2010 14:38:35 -0800 Received: from qyk38 (qyk38.prod.google.com [10.241.83.166]) by wpaz5.hot.corp.google.com with ESMTP id o28Mc7uI012971 for ; Mon, 8 Mar 2010 14:38:34 -0800 Received: by qyk38 with SMTP id 38so3796076qyk.27 for ; Mon, 08 Mar 2010 14:38:34 -0800 (PST) MIME-Version: 1.0 Date: Mon, 8 Mar 2010 14:38:34 -0800 Message-ID: <377f3a9b1003081438y25427497j199be53d44075525@mail.gmail.com> From: Rob Earhart Content-Type: multipart/alternative; boundary=0016e64718e8a9b718048151b90d Subject: [Qemu-devel] Submitting a change...? List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --0016e64718e8a9b718048151b90d Content-Type: text/plain; charset=ISO-8859-1 So, I have a patch I'd like to submit. It's pretty simple - when using a differencing disk and loading a snapshot, it includes the backing disks in the search. It seems to work fine on my machine. I'm not sure what the procedure for submitting changes is; it's been a long time since I've contributed to an open source project. I used "git clone" to pull down the source and make my modifications; "git diff HEAD" appears to be reasonable, "git commit --dry-run" appears to correctly identify the modified files... but I don't know what comes next. :-) So now what? Would running "git commit" do the right thing? Should I generate a diff and send the output somewhere for review and possible approval? Something else? Thanks, )Rob --0016e64718e8a9b718048151b90d Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
So, I have a patch I'd like to submit. =A0It's pretty simple -= when using a differencing disk and loading a snapshot, it includes the bac= king disks in the search. =A0It seems to work fine on my machine.

I'm not sure what the procedure for submitting changes i= s; it's been a long time since I've contributed to an open source p= roject. =A0I used "git clone" to pull down the source and make my= modifications; "git diff HEAD" appears to be reasonable, "g= it commit --dry-run" appears to correctly identify the modified files.= .. but I don't know what comes next. =A0:-)

So now what? =A0Would running "git commit" do= the right thing? =A0Should I generate a diff and send the output somewhere= for review and possible approval? =A0Something else?

T= hanks,
)Rob
--0016e64718e8a9b718048151b90d--