From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Cc: "Paul Burton" <pburton@wavecomp.com>,
"Jan Kiszka" <jan.kiszka@web.de>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
"Helge Deller" <deller@gmx.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Antony Pavlov" <antonynpavlov@gmail.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Joel Stanley" <joel@jms.id.au>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Leif Lindholm" <leif.lindholm@linaro.org>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"Peter Chubb" <peter.chubb@nicta.com.au>,
"Fabien Chouteau" <chouteau@adacore.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Radoslaw Biernacki" <radoslaw.biernacki@linaro.org>,
"Thomas Huth" <huth@tuxfamily.org>,
"Andrew Baumann" <Andrew.Baumann@microsoft.com>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Michael Walle" <michael@walle.cc>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH 18/21] hw/mips: Let the machine be the owner of the system memory
Date: Mon, 21 Oct 2019 13:28:48 +0200 [thread overview]
Message-ID: <3780f13b-8c03-fd96-47e3-1e1da3ecde2a@redhat.com> (raw)
In-Reply-To: <CAL1e-=gbwabWNm1GyzG2K4Y+7dseUMpsj8+cpzNgJ5NT1P+SLQ@mail.gmail.com>
On 10/21/19 1:10 PM, Aleksandar Markovic wrote:
> On Monday, October 21, 2019, Philippe Mathieu-Daudé <philmd@redhat.com
> <mailto:philmd@redhat.com>> wrote:
>
> On 10/21/19 12:56 PM, Aleksandar Markovic wrote:
>
>
>
> On Monday, October 21, 2019, Philippe Mathieu-Daudé
> <philmd@redhat.com <mailto:philmd@redhat.com>
> <mailto:philmd@redhat.com <mailto:philmd@redhat.com>>> wrote:
>
> Hi Aleksandar,
>
> On 10/21/19 8:25 AM, Aleksandar Markovic wrote:
>
>
>
> On Monday, October 21, 2019, Philippe Mathieu-Daudé
> <philmd@redhat.com <mailto:philmd@redhat.com>
> <mailto:philmd@redhat.com <mailto:philmd@redhat.com>>
> <mailto:philmd@redhat.com <mailto:philmd@redhat.com>
> <mailto:philmd@redhat.com <mailto:philmd@redhat.com>>>> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé
> <philmd@redhat.com <mailto:philmd@redhat.com>
> <mailto:philmd@redhat.com <mailto:philmd@redhat.com>>
> <mailto:philmd@redhat.com
> <mailto:philmd@redhat.com> <mailto:philmd@redhat.com
> <mailto:philmd@redhat.com>>>>
> ---
> hw/mips/boston.c | 2 +-
> hw/mips/mips_fulong2e.c | 3 ++-
> hw/mips/mips_jazz.c | 2 +-
> hw/mips/mips_malta.c | 2 +-
> hw/mips/mips_mipssim.c | 2 +-
> hw/mips/mips_r4k.c | 3 ++-
> 6 files changed, 8 insertions(+), 6 deletions(-)
>
>
> Philippe, can this patch be applied independently (on other
> patches of this series)?
>
>
> Unfortunately not because patch #9 changed the prototype of
> memory_region_allocate_system_memory() so this patch alone
> won't build.
>
> I rather expect this series goes as a whole via the
> machine-next
> tree.
>
> Do you mind giving your Acked-by tag to this patch?
>
>
> I can't, sorry, for MIPS target, we don't accept patches with
> empty commit messages.
>
>
> I see, I'v been wondering what to do, if simply repeating the patch
> subject or the cover, but since the series applies to all targets,
> this seems overkill. I think I'll simply repeat the subject then.
>
>
> Can't you at least add a sentence on why is this needed, or what is
> achieved?
You are alright, I'll do.
>
> Thanks,
>
> A.
>
>
> A.
>
>
> Thanks,
>
> Phil.
>
>
>
> diff --git a/hw/mips/boston.c b/hw/mips/boston.c
> index ca7d813a52..8445fee0f1 100644
> --- a/hw/mips/boston.c
> +++ b/hw/mips/boston.c
> @@ -474,7 +474,7 @@ static void
> boston_mach_init(MachineState *machine)
> memory_region_add_subregion_overlap(sys_mem,
> 0x18000000,
> flash, 0);
>
> ddr = g_new(MemoryRegion, 1);
> - memory_region_allocate_system_memory(ddr, NULL,
> "boston.ddr",
> + memory_region_allocate_system_memory(ddr,
> machine,
> "boston.ddr",
>
> machine->ram_size);
> memory_region_add_subregion_overlap(sys_mem,
> 0x80000000, ddr, 0);
>
> diff --git a/hw/mips/mips_fulong2e.c
> b/hw/mips/mips_fulong2e.c
> index cf537dd7e6..d5a5cef619 100644
> --- a/hw/mips/mips_fulong2e.c
> +++ b/hw/mips/mips_fulong2e.c
> @@ -318,7 +318,8 @@ static void
> mips_fulong2e_init(MachineState
> *machine)
> ram_size = 256 * MiB;
>
> /* allocate RAM */
> - memory_region_allocate_system_memory(ram, NULL,
> "fulong2e.ram",
> ram_size);
> + memory_region_allocate_system_memory(ram,
> machine,
> +
> "fulong2e.ram",
> ram_size);
> memory_region_init_ram(bios, NULL,
> "fulong2e.bios",
> BIOS_SIZE,
> &error_fatal);
> memory_region_set_readonly(bios, true);
> diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c
> index 8d010a0b6e..88b125855f 100644
> --- a/hw/mips/mips_jazz.c
> +++ b/hw/mips/mips_jazz.c
> @@ -188,7 +188,7 @@ static void
> mips_jazz_init(MachineState
> *machine,
> cc->do_transaction_failed =
> mips_jazz_do_transaction_failed;
>
> /* allocate RAM */
> - memory_region_allocate_system_memory(ram, NULL,
> "mips_jazz.ram",
> + memory_region_allocate_system_memory(ram,
> machine,
> "mips_jazz.ram",
>
> machine->ram_size);
> memory_region_add_subregion(address_space,
> 0, ram);
>
> diff --git a/hw/mips/mips_malta.c
> b/hw/mips/mips_malta.c
> index 4d9c64b36a..af56a29ccb 100644
> --- a/hw/mips/mips_malta.c
> +++ b/hw/mips/mips_malta.c
> @@ -1267,7 +1267,7 @@ void
> mips_malta_init(MachineState
> *machine)
> }
>
> /* register RAM at high address where it is
> undisturbed by IO */
> -
> memory_region_allocate_system_memory(ram_high, NULL,
> "mips_malta.ram",
> +
> memory_region_allocate_system_memory(ram_high, machine,
> "mips_malta.ram",
> ram_size);
> memory_region_add_subregion(system_memory,
> 0x80000000, ram_high);
>
> diff --git a/hw/mips/mips_mipssim.c
> b/hw/mips/mips_mipssim.c
> index 282bbecb24..c1933231e2 100644
> --- a/hw/mips/mips_mipssim.c
> +++ b/hw/mips/mips_mipssim.c
> @@ -166,7 +166,7 @@ mips_mipssim_init(MachineState
> *machine)
> qemu_register_reset(main_cpu_reset, reset_info);
>
> /* Allocate RAM. */
> - memory_region_allocate_system_memory(ram, NULL,
> "mips_mipssim.ram",
> + memory_region_allocate_system_memory(ram,
> machine,
> "mips_mipssim.ram",
> ram_size);
> memory_region_init_ram(bios, NULL,
> "mips_mipssim.bios", BIOS_SIZE,
> &error_fatal);
> diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c
> index bc0be26544..59f8cacfb6 100644
> --- a/hw/mips/mips_r4k.c
> +++ b/hw/mips/mips_r4k.c
> @@ -203,7 +203,8 @@ void
> mips_r4k_init(MachineState *machine)
> " maximum 256MB", ram_size
> / MiB);
> exit(1);
> }
> - memory_region_allocate_system_memory(ram, NULL,
> "mips_r4k.ram",
> ram_size);
> + memory_region_allocate_system_memory(ram,
> machine,
> "mips_r4k.ram",
> + ram_size);
>
>
> memory_region_add_subregion(address_space_mem, 0, ram);
>
> -- 2.21.0
>
>
next prev parent reply other threads:[~2019-10-21 11:30 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 22:56 [PATCH 00/21] hw: Let the machine be the owner of the system memory Philippe Mathieu-Daudé
2019-10-20 22:56 ` [PATCH 01/21] hw/arm/xilinx_zynq: Use the IEC binary prefix definitions Philippe Mathieu-Daudé
2019-10-21 16:49 ` Richard Henderson
2019-10-21 20:47 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 02/21] hw/arm/mps2: " Philippe Mathieu-Daudé
2019-10-21 16:50 ` Richard Henderson
2019-10-21 20:47 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 03/21] hw/arm/collie: Create the RAM in the board Philippe Mathieu-Daudé
2019-10-21 16:55 ` Richard Henderson
2019-10-21 20:49 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 04/21] hw/arm/omap2: " Philippe Mathieu-Daudé
2019-10-21 16:59 ` Richard Henderson
2019-10-21 17:18 ` Philippe Mathieu-Daudé
2019-10-20 22:56 ` [PATCH 05/21] hw/arm/omap1: " Philippe Mathieu-Daudé
2019-10-21 17:03 ` Richard Henderson
2019-10-20 22:56 ` [PATCH 06/21] hw/arm/digic4: Inline digic4_board_setup_ram() function Philippe Mathieu-Daudé
2019-10-21 17:04 ` Richard Henderson
2019-10-21 20:51 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 07/21] hw: Drop QOM ownership on memory_region_allocate_system_memory() calls Philippe Mathieu-Daudé
2019-10-21 23:18 ` Alistair Francis
2019-10-22 9:47 ` Artyom Tarasenko
2019-10-20 22:56 ` [PATCH 08/21] hw/alpha/dp264: Create the RAM in the board Philippe Mathieu-Daudé
2019-10-21 8:53 ` Philippe Mathieu-Daudé
2019-10-21 17:27 ` Richard Henderson
2019-10-21 17:34 ` Philippe Mathieu-Daudé
2019-10-20 22:56 ` [PATCH 09/21] hw: Let memory_region_allocate_system_memory take MachineState argument Philippe Mathieu-Daudé
2019-10-21 7:27 ` Thomas Huth
2019-10-21 8:32 ` Philippe Mathieu-Daudé
2019-10-21 23:19 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 10/21] hw/core: Let the machine be the owner of the system memory Philippe Mathieu-Daudé
2019-10-21 23:20 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 11/21] hw/alpha: " Philippe Mathieu-Daudé
2019-10-21 17:14 ` Richard Henderson
2019-10-21 17:19 ` Richard Henderson
2019-10-21 17:26 ` Philippe Mathieu-Daudé
2019-10-20 22:56 ` [PATCH 12/21] hw/arm: " Philippe Mathieu-Daudé
2019-10-21 9:22 ` Peter Maydell
2019-10-21 9:33 ` Philippe Mathieu-Daudé
2019-10-21 9:39 ` Peter Maydell
2019-10-21 10:24 ` Philippe Mathieu-Daudé
2019-10-21 14:57 ` Dr. David Alan Gilbert
2021-02-03 16:05 ` Philippe Mathieu-Daudé
2019-10-20 22:56 ` [PATCH 13/21] hw/cris: " Philippe Mathieu-Daudé
2019-10-21 17:28 ` Richard Henderson
2019-10-21 20:56 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 14/21] hw/hppa: " Philippe Mathieu-Daudé
2019-10-21 17:29 ` Richard Henderson
2019-10-21 20:56 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 15/21] hw/i386: " Philippe Mathieu-Daudé
2019-10-21 17:29 ` Richard Henderson
2019-10-21 20:56 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 16/21] hw/lm32: " Philippe Mathieu-Daudé
2019-10-21 17:30 ` Richard Henderson
2019-10-21 20:57 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 17/21] hw/m68k: " Philippe Mathieu-Daudé
2019-10-21 7:28 ` Thomas Huth
2019-10-21 17:31 ` Richard Henderson
2019-10-21 20:57 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 18/21] hw/mips: " Philippe Mathieu-Daudé
2019-10-21 6:25 ` Aleksandar Markovic
2019-10-21 8:34 ` Philippe Mathieu-Daudé
2019-10-21 10:56 ` Aleksandar Markovic
2019-10-21 11:05 ` Philippe Mathieu-Daudé
2019-10-21 11:10 ` Aleksandar Markovic
2019-10-21 11:28 ` Philippe Mathieu-Daudé [this message]
2019-10-21 12:10 ` Aleksandar Markovic
2019-10-21 19:24 ` [EXTERNAL][PATCH " Aleksandar Markovic
2019-10-20 22:56 ` [PATCH 19/21] hw/ppc: " Philippe Mathieu-Daudé
2019-10-21 0:44 ` David Gibson
2019-10-21 17:33 ` Richard Henderson
2019-10-20 22:56 ` [PATCH 20/21] hw/sparc: " Philippe Mathieu-Daudé
2019-10-21 17:33 ` Richard Henderson
2019-10-20 22:56 ` [PATCH 21/21] hw/core: Assert memory_region_allocate_system_memory has machine owner Philippe Mathieu-Daudé
2019-10-21 17:41 ` Richard Henderson
2019-10-21 21:00 ` Alistair Francis
2019-10-21 0:03 ` [PATCH 00/21] hw: Let the machine be the owner of the system memory no-reply
2019-10-21 8:52 ` Philippe Mathieu-Daudé
2019-10-21 14:31 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3780f13b-8c03-fd96-47e3-1e1da3ecde2a@redhat.com \
--to=philmd@redhat.com \
--cc=Andrew.Baumann@microsoft.com \
--cc=aleksandar.m.mail@gmail.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=alistair@alistair23.me \
--cc=amarkovic@wavecomp.com \
--cc=andrew.smirnov@gmail.com \
--cc=andrew@aj.id.au \
--cc=antonynpavlov@gmail.com \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=b.galvani@gmail.com \
--cc=chouteau@adacore.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=deller@gmx.de \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=frederic.konrad@adacore.com \
--cc=hpoussin@reactos.org \
--cc=huth@tuxfamily.org \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@web.de \
--cc=jcd@tribudubois.net \
--cc=joel@jms.id.au \
--cc=leif.lindholm@linaro.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pburton@wavecomp.com \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=radoslaw.biernacki@linaro.org \
--cc=robh@kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).