From: Richard Henderson <richard.henderson@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>, qemu-devel@nongnu.org
Cc: philmd@linaro.org, ale@rev.ng, anjo@rev.ng, bcain@quicinc.com,
quic_mathbern@quicinc.com
Subject: Re: [PATCH 08/21] Hexagon (target/hexagon) Clean up pred_written usage
Date: Wed, 26 Apr 2023 22:23:06 +0100 [thread overview]
Message-ID: <379e70f9-2d04-dddc-fe5b-d4eee3bde62f@linaro.org> (raw)
In-Reply-To: <20230426004202.1319250-1-tsimpson@quicinc.com>
On 4/26/23 01:42, Taylor Simpson wrote:
> Only endloop instructions will conditionally write to a predicate.
> When there is an endloop instruction, we preload the values into
> new_pred_value.
>
> The only place pred_written is needed is when HEX_DEBUG is on.
>
> We remove the last use of check_for_attrib. However, new uses will be
> introduced later in this series, so we change it to "static inline".
This is insufficient -- clang will warn about unused inline functions within the main C
file (as opposed to #included).
Use __attribute__((unused)) instead, and remove it when it gains new unconditional uses.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-04-26 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 0:42 [PATCH 08/21] Hexagon (target/hexagon) Clean up pred_written usage Taylor Simpson
2023-04-26 21:23 ` Richard Henderson [this message]
2023-04-26 21:27 ` Taylor Simpson
2023-04-27 7:37 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=379e70f9-2d04-dddc-fe5b-d4eee3bde62f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).