* [PATCH] configure: Only build s390-ccw BIOS for system emulation
@ 2021-01-24 16:17 Philippe Mathieu-Daudé
2021-01-25 6:06 ` Thomas Huth
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-24 16:17 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Cornelia Huck, Laurent Vivier,
Philippe Mathieu-Daudé, Christian Borntraeger, qemu-s390x
It is pointless to build the s390-ccw BIOS when only user-mode
emulation is built. Only build it when system mode emulation is
selected.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 6f6a319c2f6..d5e97ff2d52 100755
--- a/configure
+++ b/configure
@@ -5453,7 +5453,7 @@ if { test "$cpu" = "i386" || test "$cpu" = "x86_64"; } && \
fi
# Only build s390-ccw bios if we're on s390x and the compiler has -march=z900
-if test "$cpu" = "s390x" ; then
+if test "$cpu" = "s390x" && test "$softmmu" = yes; then
write_c_skeleton
if compile_prog "-march=z900" ""; then
roms="$roms s390-ccw"
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] configure: Only build s390-ccw BIOS for system emulation
2021-01-24 16:17 [PATCH] configure: Only build s390-ccw BIOS for system emulation Philippe Mathieu-Daudé
@ 2021-01-25 6:06 ` Thomas Huth
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2021-01-25 6:06 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Christian Borntraeger, qemu-s390x, Cornelia Huck, Laurent Vivier
On 24/01/2021 17.17, Philippe Mathieu-Daudé wrote:
> It is pointless to build the s390-ccw BIOS when only user-mode
> emulation is built. Only build it when system mode emulation is
> selected.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 6f6a319c2f6..d5e97ff2d52 100755
> --- a/configure
> +++ b/configure
> @@ -5453,7 +5453,7 @@ if { test "$cpu" = "i386" || test "$cpu" = "x86_64"; } && \
> fi
>
> # Only build s390-ccw bios if we're on s390x and the compiler has -march=z900
> -if test "$cpu" = "s390x" ; then
> +if test "$cpu" = "s390x" && test "$softmmu" = yes; then
Actually, you could even improve by checking whether we're building the
s390x-softmmu target (the bios is also not required if we're just building
the x86_64-softmmu target on a s390x host, for example).
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-25 6:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-24 16:17 [PATCH] configure: Only build s390-ccw BIOS for system emulation Philippe Mathieu-Daudé
2021-01-25 6:06 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).