From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C169DC2D0A3 for ; Fri, 6 Nov 2020 13:19:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05F5320702 for ; Fri, 6 Nov 2020 13:19:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K7AQWTeX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05F5320702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kb1eA-000513-VD for qemu-devel@archiver.kernel.org; Fri, 06 Nov 2020 08:19:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb1cK-00045l-NJ for qemu-devel@nongnu.org; Fri, 06 Nov 2020 08:17:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:56816) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kb1cH-0005HG-4G for qemu-devel@nongnu.org; Fri, 06 Nov 2020 08:17:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604668640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lg19tKNtTu5cOQgzFgpqCJsHJ+WoqwugycYFlsvSLX4=; b=K7AQWTeX3f2dOWI/fLBq007ZUHYWlOKPH4veU6HZpG/deTDOHp9kgWivsiMdpUHc5AtzsW xthnZvpfWFbwdz0GBW7URjEULuKIcPKvS3wfcMcQQUOR4g7pDGf0LIYnWFfPQQZ5k3EvqE 8suvPxcfs2eQST/qDlOebmpksXGq0ic= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-3R5GdIWTOlK7WGm3V6pjiQ-1; Fri, 06 Nov 2020 08:17:16 -0500 X-MC-Unique: 3R5GdIWTOlK7WGm3V6pjiQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DBB691018F61; Fri, 6 Nov 2020 13:17:14 +0000 (UTC) Received: from [10.3.114.103] (ovpn-114-103.phx2.redhat.com [10.3.114.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F7D64DA7F; Fri, 6 Nov 2020 13:17:13 +0000 (UTC) Subject: Re: [PATCH V2 1/2] plugins: Fix resource leak in connect_socket() To: AlexChen , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Michael Tokarev , Laurent Vivier References: <5FA4AE11.6060701@huawei.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <37c069f2-b137-b68d-9fb5-45a98b84aa0c@redhat.com> Date: Fri, 6 Nov 2020 07:17:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <5FA4AE11.6060701@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/06 06:30:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , QEMU , zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/5/20 7:59 PM, AlexChen wrote: > Close the fd when the connect() fails. > > Reported-by: Euler Robot > Signed-off-by: Alex Chen Your From: line ("AlexChen") is spelled differently than your S-o-b: line ("Alex Chen"). While this is not fatal to the patch, it is confusing, so you may want to update your git settings to produce mail spelled in the same manner as the S-o-b. Also, although you did manage to send a 0/2 letter, you did not thread things: 0/2 Message-ID: <5FA4AE0B.1000007@huawei.com> 1/2 Message-ID: Message-ID: <5FA4AE11.6060701@huawei.com>, but no In-Reply-To: or References: headers, which means it is a new top-level thread. You may want to figure out why your mail setup is not preserving threading. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org