From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] qtest: Move accel code to accel/qtest.c
Date: Tue, 23 Apr 2019 00:17:08 +0200 [thread overview]
Message-ID: <37c1d38f-06b6-fb8e-2cc1-c4094ae05931@redhat.com> (raw)
In-Reply-To: <20190422220814.GA25134@habkost.net>
On 4/23/19 12:08 AM, Eduardo Habkost wrote:
> On Mon, Apr 22, 2019 at 11:56:18PM +0200, Philippe Mathieu-Daudé wrote:
>> Hi Eduardo,
>>
>> On 4/22/19 11:04 PM, Eduardo Habkost wrote:
>>> QTest has two parts: the server (-qtest) and the accelerator
>>> (-machine accel=qtest). The accelerator depends on CONFIG_POSIX
>>> due to its usage of sigwait(), but the server doesn't.
>>>
>>> Move the accel code to accel/qtest.c. Later we will disable
>>> compilation of accel/qtest.c on non-POSIX systems.
>>>
> [...]
>>> +#include "qemu/module.h"
>>
>> Why include "qemu/module.h"?
>> I guess you don't need it.
>
> That's where the type_init() macro is defined.
Oh correct...
I tried to remove it/compile and it worked because it is pulled by:
"sysemu/cpus.h"
-> "qemu/timer.h"
-> "qemu-common.h"
-> "qemu/module.h"
Thanks!
>>> +type_init(qtest_type_init);
> [...]
>
>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Thanks!
>
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] qtest: Move accel code to accel/qtest.c
Date: Tue, 23 Apr 2019 00:17:08 +0200 [thread overview]
Message-ID: <37c1d38f-06b6-fb8e-2cc1-c4094ae05931@redhat.com> (raw)
Message-ID: <20190422221708.qtZkulyiwFcs9_InmYu93Z9qaHm9ngAUI-hWhpu9ogQ@z> (raw)
In-Reply-To: <20190422220814.GA25134@habkost.net>
On 4/23/19 12:08 AM, Eduardo Habkost wrote:
> On Mon, Apr 22, 2019 at 11:56:18PM +0200, Philippe Mathieu-Daudé wrote:
>> Hi Eduardo,
>>
>> On 4/22/19 11:04 PM, Eduardo Habkost wrote:
>>> QTest has two parts: the server (-qtest) and the accelerator
>>> (-machine accel=qtest). The accelerator depends on CONFIG_POSIX
>>> due to its usage of sigwait(), but the server doesn't.
>>>
>>> Move the accel code to accel/qtest.c. Later we will disable
>>> compilation of accel/qtest.c on non-POSIX systems.
>>>
> [...]
>>> +#include "qemu/module.h"
>>
>> Why include "qemu/module.h"?
>> I guess you don't need it.
>
> That's where the type_init() macro is defined.
Oh correct...
I tried to remove it/compile and it worked because it is pulled by:
"sysemu/cpus.h"
-> "qemu/timer.h"
-> "qemu-common.h"
-> "qemu/module.h"
Thanks!
>>> +type_init(qtest_type_init);
> [...]
>
>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Thanks!
>
next prev parent reply other threads:[~2019-04-22 22:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 21:04 [Qemu-devel] [PATCH 0/3] Remove AccelClass::available field Eduardo Habkost
2019-04-22 21:04 ` Eduardo Habkost
2019-04-22 21:04 ` [Qemu-devel] [PATCH 1/3] qtest: Move accel code to accel/qtest.c Eduardo Habkost
2019-04-22 21:04 ` Eduardo Habkost
2019-04-22 21:56 ` Philippe Mathieu-Daudé
2019-04-22 21:56 ` Philippe Mathieu-Daudé
2019-04-22 22:08 ` Eduardo Habkost
2019-04-22 22:08 ` Eduardo Habkost
2019-04-22 22:17 ` Philippe Mathieu-Daudé [this message]
2019-04-22 22:17 ` Philippe Mathieu-Daudé
2019-04-23 5:07 ` Thomas Huth
2019-04-23 5:07 ` Thomas Huth
2019-04-23 11:08 ` [Qemu-devel] [PATCH] fixup! " Eduardo Habkost
2019-04-23 11:08 ` Eduardo Habkost
2019-04-23 11:29 ` Thomas Huth
2019-04-23 11:29 ` Thomas Huth
2019-04-22 21:04 ` [Qemu-devel] [PATCH 2/3] qtest: Don't compile qtest accel on non-POSIX systems Eduardo Habkost
2019-04-22 21:04 ` Eduardo Habkost
2019-04-22 22:20 ` Philippe Mathieu-Daudé
2019-04-22 22:20 ` Philippe Mathieu-Daudé
2019-04-23 5:09 ` Thomas Huth
2019-04-23 5:09 ` Thomas Huth
2019-04-22 21:04 ` [Qemu-devel] [PATCH 3/3] accel: Remove unused AccelClass::available field Eduardo Habkost
2019-04-22 21:04 ` Eduardo Habkost
2019-04-22 22:20 ` Philippe Mathieu-Daudé
2019-04-22 22:20 ` Philippe Mathieu-Daudé
2019-04-23 5:09 ` Thomas Huth
2019-04-23 5:09 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37c1d38f-06b6-fb8e-2cc1-c4094ae05931@redhat.com \
--to=philmd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).