From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Markus Armbruster <armbru@redhat.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Gan Qixin <ganqixin@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Chenqun \(kuhn\)" <kuhn.chenqun@huawei.com>
Subject: Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code
Date: Fri, 6 Nov 2020 15:08:14 +0100 [thread overview]
Message-ID: <37c519e4-d72b-944c-ed70-038f9c606be9@redhat.com> (raw)
In-Reply-To: <CAFEAcA-_5vRbsi5fFpyLV2OyDX5TVrpAx7_Z43wqvb1zhQO_8w@mail.gmail.com>
On 11/6/20 2:39 PM, Peter Maydell wrote:
> On Fri, 6 Nov 2020 at 13:07, Markus Armbruster <armbru@redhat.com> wrote:
>> The current "warn at 80, error at 90" is a compromise. It's the result
>> of a lengthy argument. Why reopen it?
>
> There was some previous discussion under this thread:
> https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg05653.html
>
> which I think is what prompted this patch.
Can we keep the error please? Maybe 132 is the next display logical
limit once we increased the warning from 80 to 100.
I understand hardware evolved, we have larger displays with better
resolution and can fit more characters in a line.
I am a bit wary however functions become heavier (more code into
a single function). Maybe this checkpatch change should go with
a another one warning when a function has more than 80 lines,
excluding comments? (Even 80 is too much for my taste).
Regards,
Phil.
next prev parent reply other threads:[~2020-11-06 14:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:42 [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code Gan Qixin
2020-11-06 11:06 ` Peter Maydell
2020-11-06 13:07 ` Markus Armbruster
2020-11-06 13:39 ` Peter Maydell
2020-11-06 14:08 ` Philippe Mathieu-Daudé [this message]
2020-11-06 14:16 ` Peter Maydell
2020-11-06 14:49 ` Philippe Mathieu-Daudé
2020-11-06 16:08 ` Markus Armbruster
2020-11-06 16:19 ` Peter Maydell
2020-11-09 5:53 ` ganqixin
2020-11-09 9:01 ` Markus Armbruster
2020-11-30 13:26 ` Peter Maydell
2020-12-02 9:19 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37c519e4-d72b-944c-ed70-038f9c606be9@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).