From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86961C47074 for ; Mon, 8 Jan 2024 01:25:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMeNZ-0008A7-1X; Sun, 07 Jan 2024 20:24:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMeNX-00089p-UD for qemu-devel@nongnu.org; Sun, 07 Jan 2024 20:24:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMeNW-0000Np-3U for qemu-devel@nongnu.org; Sun, 07 Jan 2024 20:24:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704677073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zR4HYJF5zMqs/5iCnmncn7xcU4rl6McY+Iy07koCy9c=; b=JEXlOoYXh4vmfZICcGkUpQfGmv6wFn05+d6WnmmEn1/QDm40TaSdJzGU9mW6hhYNOlrc1N vxpzlpRQtFBfIXTegbcVCJz/0eVYo6iokDKRtng+rkSgj2BvuMoz2dRoFQVgiWtTfKrd4K EGHPirU5vHoBvyhaYqeVIy6CsAAghlg= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-KnuE8bDkN0aljM96T2Htfw-1; Sun, 07 Jan 2024 20:24:31 -0500 X-MC-Unique: KnuE8bDkN0aljM96T2Htfw-1 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-6d9b2360ed7so1883135b3a.3 for ; Sun, 07 Jan 2024 17:24:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704677070; x=1705281870; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zR4HYJF5zMqs/5iCnmncn7xcU4rl6McY+Iy07koCy9c=; b=FihGrD21ZCCnAm3ahtgZR7X2HpH2wBBIBCy2gJy2GiTw9XuduF52+cTBZ/3KQ/VXxX VreZKe5JzpFXUsfyF3F5BzxmV2bfRaoxNDbhJxstGOzAgbD4NTShtONo0qAG4oEIq07T /u4NnuVNzupds8Ds3qRrGvRrhujh6ukNnr5wUwRWL3hkXz+T4DpbHjw35pEvc9udEOYv DMjF9f6jAcRGgNGXhSFaJXg1EFa+47t7r5s9ueNhxR3/rUF9LwPnJrI7HhDwQ1PPAKJL Qb84qlWuvhPicWPdl0A78MuGBVUDCG50lTBEV6POF5tp1iaDZ85cLhrWLR/8LUqv4k+z th7Q== X-Gm-Message-State: AOJu0Yz2veJALyQoX02ZZewraDTIXYKXteM97LUg1SppkJMDzTyGWCYs Gqgg17bb8whrxwXaqFKOgRIeAY9cfjADcRS97qdKpdMKL4Y+G5QFc4q2i2lceJQC/HoMbR2rCJ8 b1b1vVxWZaCPR9Dp50ZYr/fI= X-Received: by 2002:a05:6a00:11de:b0:6d9:bbac:a34b with SMTP id a30-20020a056a0011de00b006d9bbaca34bmr2759503pfu.14.1704677070617; Sun, 07 Jan 2024 17:24:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IFDectWINxqXLjS2sWIbSa2R4zSCnAVwRZQUO3J5NgSyIH9ow2U4yNnP2/A9y5YRbHgR491bQ== X-Received: by 2002:a05:6a00:11de:b0:6d9:bbac:a34b with SMTP id a30-20020a056a0011de00b006d9bbaca34bmr2759496pfu.14.1704677070346; Sun, 07 Jan 2024 17:24:30 -0800 (PST) Received: from [10.72.112.108] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id l2-20020a056a00140200b006d9aa4b65fasm4955573pfu.98.2024.01.07.17.24.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jan 2024 17:24:29 -0800 (PST) Message-ID: <37c885a5-d67d-443c-8059-8f23f909adf5@redhat.com> Date: Mon, 8 Jan 2024 11:24:18 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 0/9] Unified CPU type check Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, peter.maydell@linaro.org, b.galvani@gmail.com, strahinja.p.jankovic@gmail.com, imammedo@redhat.com, kfting@nuvoton.com, wuhaotsh@google.com, nieklinnenbank@gmail.com, rad@semihalf.com, quic_llindhol@quicinc.com, marcin.juszkiewicz@linaro.org, eduardo@habkost.net, marcel.apfelbaum@gmail.com, armbru@redhat.com, wangyanan55@huawei.com, vijai@behindbytes.com, palmer@dabbelt.com, alistair.francis@wdc.com, bin.meng@windriver.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, shan.gavin@gmail.com References: <20231204004726.483558-1-gshan@redhat.com> <0b2aaedf-7a4c-49f4-b4af-71f9ab693207@redhat.com> <23213dcb-16ca-4be4-9ff2-32e4fc491495@redhat.com> <2ddfcd43-b5db-4f87-922b-0d2d5dd27d77@linaro.org> From: Gavin Shan In-Reply-To: <2ddfcd43-b5db-4f87-922b-0d2d5dd27d77@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=gshan@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.098, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Phil, On 1/6/24 08:12, Philippe Mathieu-Daudé wrote: > On 13/12/23 11:54, Gavin Shan wrote: >> On 12/13/23 20:08, Philippe Mathieu-Daudé wrote: >>> On 12/12/23 05:55, Gavin Shan wrote: >>>> On 12/4/23 10:47, Gavin Shan wrote: >>>>> This series bases on Phil's repository because the prepatory commits >>>>> have been queued to the branch. >>>>> >>>>>    https://gitlab.com/philmd/qemu.git (branch: cpus-next) >>>>> >>>>> There are two places where the user specified CPU type is checked to see >>>>> if it's supported or allowed by the board: machine_run_board_init() and >>>>> mc->init(). We don't have to maintain two duplicate sets of logic. This >>>>> series intends to move the check to machine_run_board_init() so that we >>>>> have unified CPU type check. >>>>> >>>>> This series can be checked out from: >>>>> >>>>>    git@github.com:gwshan/qemu.git (branch: kvm/cpu-type) >>>>> >>>>> PATCH[1-4] refactors and improves the logic to validate CPU type in >>>>>             machine_run_board_init() >>>>> PATCH[5-9] validates the CPU type in machine_run_board_init() for the >>>>>             individual boards >>>>> >>>>> v6: https://lists.nongnu.org/archive/html/qemu-arm/2023-11/msg00768.html >>>>> v7: https://lists.nongnu.org/archive/html/qemu-arm/2023-11/msg01045.html >>>>> v8: https://lists.nongnu.org/archive/html/qemu-arm/2023-11/msg01168.html >>>>> >>>> >>>> Ping to see if there is a chance to queue it up before the Chrismas? :) >>> >>> Series queued. "Before" Christmas will depend on the final release tag. >>> >>> Thanks for the various iterations, >>> >> >> Phil, thank you for you continuous reviews and valuable comments. >> >> Yes, the final merge to master branch depends on the release plan. >> 'queue' meant to merge the series to your 'cpus-next' branch ;-) > > I had to fix 3 different issues caught by our CI. Next time please > run your series on GitLab CI, you just have to push your branch and > wait for the result :) > > Now merged as 445946f4dd..cd75cc6337. > > Happy new year! > Happy new year. I just came back from holiday. Thanks for the reminder for GitLab CI, which I don't know how to run yet. I will learn how to run it from gitlab :) Thanks, Gavin