From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org, armbru@redhat.com
Cc: famz@redhat.com
Subject: Re: [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02
Date: Mon, 2 Oct 2017 09:36:03 -0500 [thread overview]
Message-ID: <37ea08c6-ec95-2ab6-13dd-db9d270bfe5a@redhat.com> (raw)
In-Reply-To: <150694455954.126.4260615671927745603@b58463cdfd5f>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
On 10/02/2017 06:42 AM, no-reply@patchew.org wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Checking PATCH 2/3: watchdog.h: Drop local redefinition of actions enum...
> ERROR: braces {} are necessary for all arms of this statement
> #57: FILE: hw/watchdog/watchdog.c:86:
> + if (action < 0)
> [...]
Pre-existing problem, but would indeed be easy to fix up as part of this
series. I don't know if that means Markus should respin the pull request?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-10-02 14:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 11:11 [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02 Markus Armbruster
2017-10-02 11:11 ` [Qemu-devel] [PULL 1/3] qapi: Rename WatchdogExpirationAction enum Markus Armbruster
2017-10-02 11:11 ` [Qemu-devel] [PULL 2/3] watchdog.h: Drop local redefinition of actions enum Markus Armbruster
2017-10-02 11:11 ` [Qemu-devel] [PULL 3/3] watchdog: Allow setting action on the fly Markus Armbruster
2017-10-02 11:42 ` [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02 no-reply
2017-10-02 14:36 ` Eric Blake [this message]
2017-10-02 17:17 ` Markus Armbruster
2017-10-03 15:26 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37ea08c6-ec95-2ab6-13dd-db9d270bfe5a@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).