From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 662CCC636C8 for ; Thu, 15 Jul 2021 18:24:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC91B6120A for ; Thu, 15 Jul 2021 18:24:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC91B6120A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m461v-0001hI-Ti for qemu-devel@archiver.kernel.org; Thu, 15 Jul 2021 14:24:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m460v-00005q-6G; Thu, 15 Jul 2021 14:23:13 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:43718) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m460t-0004kC-PH; Thu, 15 Jul 2021 14:23:12 -0400 Received: by mail-wr1-x436.google.com with SMTP id a13so8956360wrf.10; Thu, 15 Jul 2021 11:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TCggTfEOFQatakSs/1uicTptFzpCDU7ByyHQSfMH370=; b=pS6uM9PN5+0x3HWnYRQIl2ZTOWZt8ANIkVEaPshA8eb4inpM1DMNlnOIpg7te57TGJ oiUB2weGcECdWgeSH41H7Gwk4K2FsZSNzd93vafpLw3BurxL1eaktCUey4kyYpBTZecw IttfX6VAeSoFjkUUXA3PW2mXvj2MD5qkQ76OdGT3yB4bTtEcQmgJovjKio+PEfpe6IOJ x8nJr+rbyd7U/HZ158jRSmNLp3M/K18K1NwC9w0udGkhmfw1NKHwKM7JLsqHXZZGkYLK pXvQGIvnEmIIyyV5fDyU95+dBX5ikkSRgvunoZ1GmO7nt3XUetBf2sUkqTgPu4JHWo8U sb+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TCggTfEOFQatakSs/1uicTptFzpCDU7ByyHQSfMH370=; b=cfP9Inc3KAm1/8WPmlsvD/+OfaUOZNgv1CzmpN2GoqYflRS1IQxAf8HYvRBMlBAnof x+2zV5535Tj/8LXzrT4yBWqYZhODRMJwsOgEnZ1GyHdN9A/ZIIgvJWOHXOtVb1XAuPhE x5IRNX7dTCjFWsayBe+BRIOq9pWsihS/tXu2L9CcIQ0Gq2f4Omsh8vuScjyCptut7FyN nHMDQzMVwqo91HJPMV8XNDrFjZ4vy8W7XBoknbmFQuakSn00DLjRRfXRg+Bl+1fSvWbf XVwKnlLNMj1dTKqsK+ysgR9rWtA/epQB0UASTE2kW5wvQEqVDWAw2jx2Z3pgOF8LSyp9 mE2Q== X-Gm-Message-State: AOAM531ZYnXwtQszGmZqs8Mt8P5wIuhNOdiQwh+bnz0/gZmzMq0z9qX0 0mYUzER3xxIXgEmJtZCd12wzBPli33YM7Q== X-Google-Smtp-Source: ABdhPJyvoxKYBWzvwnAC/dN4dY7Jfc/w/6A5yifu1BmZyy/F1f5S9/h4qlBs7cvCejEmky833cbsBg== X-Received: by 2002:a5d:4d0b:: with SMTP id z11mr7134222wrt.411.1626373389164; Thu, 15 Jul 2021 11:23:09 -0700 (PDT) Received: from [192.168.1.24] (abordeaux-654-1-74-136.w109-214.abo.wanadoo.fr. [109.214.221.136]) by smtp.gmail.com with ESMTPSA id o11sm8941481wmc.2.2021.07.15.11.23.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jul 2021 11:23:08 -0700 (PDT) Subject: Re: [PATCH] target/arm: Remove duplicate 'plus1' function from Neon and SVE decode To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210715095341.701-1-peter.maydell@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <37f7fefe-db63-26d1-8a9d-d974b754890b@amsat.org> Date: Thu, 15 Jul 2021 20:23:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210715095341.701-1-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/15/21 11:53 AM, Peter Maydell wrote: > The Neon and SVE decoders use private 'plus1' functions to implement > "add one" for the !function decoder syntax. We have a generic > "plus_1" function in translate.h, so use that instead. > > Signed-off-by: Peter Maydell > --- > target/arm/neon-ls.decode | 4 ++-- > target/arm/neon-shared.decode | 2 +- > target/arm/sve.decode | 2 +- > target/arm/translate-neon.c | 5 ----- > target/arm/translate-sve.c | 5 ----- > 5 files changed, 4 insertions(+), 14 deletions(-) Reviewed-by: Philippe Mathieu-Daudé