From: Eric Blake <eblake@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] 9pfs: don't try to flush self and avoid QEMU hang on reset
Date: Tue, 21 Mar 2017 10:42:08 -0500 [thread overview]
Message-ID: <380e9907-d887-a392-dbd8-41228f313a31@redhat.com> (raw)
In-Reply-To: <20170321154229.1084c0e7@bahia.lan>
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
On 03/21/2017 09:42 AM, Greg Kurz wrote:
>>> This insane behavior is likely to denote a bug in the client, and it would
>>> deserve an Rerror message to be sent back. Unfortunately, the protocol
>>> allows it and requires all flush requests to suceed (only a Tflush response
>>
>> s/suceed/succeed/
The pull request still has the typo,
>>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>
>
> Oh, I've sent a v2 for this patch (error_report() a warning) and it is
> actually part of the pull request I've sent earlier today... dunno how
> to have your Reviewed-by: added there.
If you really want it, send a v2 pull request before Peter merges v1
(and an explicit NACK on the v1 cover letter will make your intentions
clear). But at this point, I'm fine if the v1 pull request goes in
untouched.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2017-03-21 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 16:33 [Qemu-devel] [PATCH] 9pfs: don't try to flush self and avoid QEMU hang on reset Greg Kurz
2017-03-21 14:01 ` Eric Blake
2017-03-21 14:42 ` Greg Kurz
2017-03-21 15:42 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=380e9907-d887-a392-dbd8-41228f313a31@redhat.com \
--to=eblake@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).