From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "QEMU Trivial" <qemu-trivial@nongnu.org>,
"Guan Xuetao" <gxt@mprc.pku.edu.cn>,
"Richard Henderson" <richard.henderson@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs
Date: Thu, 23 Jul 2020 17:19:03 +0200 [thread overview]
Message-ID: <381e22ef-0eef-cce4-2801-9066559ee30a@redhat.com> (raw)
In-Reply-To: <CAFEAcA8=38rqyH==tVeCMz2-MUdJWSSTcS79EAHCBGMuBgarhA@mail.gmail.com>
On 23/07/2020 16.50, Peter Maydell wrote:
> On Thu, 23 Jul 2020 at 14:23, Thomas Huth <thuth@redhat.com> wrote:
>>
>> The dependency on curses has been removed in commit c7a856b42e403e2b
>> ("target/unicore32: Prefer qemu_semihosting_log_out() over curses").
>> So we can remove the related lines in the Makefile now, too.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> Another, unrelated, CONFIG_CURSES oddity:
> hw/input/virtio-input-hid.c has an "#undef CONFIG_CURSES"
> before it includes ui/console.h. But that header file
> doesn't do anything different if CONFIG_CURSES is defined,
> so I think the undef is now useless and can be removed.
There used to be some curses stuff in that header, but it has been
removed more than two years ago (see commit b0766612d16da18). So yes, I
think you're right, that #undef CONFIG_CURSES can be removed now. Care
to send a patch?
Thomas
next prev parent reply other threads:[~2020-07-23 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 13:22 [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs Thomas Huth
2020-07-23 13:42 ` Philippe Mathieu-Daudé
2020-07-23 13:45 ` Thomas Huth
2020-07-23 15:11 ` Philippe Mathieu-Daudé
2020-07-23 14:50 ` Peter Maydell
2020-07-23 15:19 ` Thomas Huth [this message]
2020-07-25 0:59 ` Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=381e22ef-0eef-cce4-2801-9066559ee30a@redhat.com \
--to=thuth@redhat.com \
--cc=f4bug@amsat.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).