From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94EB4C433E8 for ; Thu, 23 Jul 2020 15:19:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D879207BB for ; Thu, 23 Jul 2020 15:19:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="C2j0hfrM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D879207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyd0g-0007NF-L0 for qemu-devel@archiver.kernel.org; Thu, 23 Jul 2020 11:19:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyd07-0006wj-Cx for qemu-devel@nongnu.org; Thu, 23 Jul 2020 11:19:15 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:33997 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jyd05-0008AP-Dx for qemu-devel@nongnu.org; Thu, 23 Jul 2020 11:19:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595517551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=SSmXm6AWoVtLcUQgIKpdWbxCc8XbX9fqAQzTiTxyR40=; b=C2j0hfrMBJpDwP+hhl8HC69kRbPNrEqqH2FENs0WdPpf1QrX+qDUQ4BlzT3ioLUC0WE3zc VSj0re9j/P59JSCDzO8Agpl6Twld3/CMeURhRsK02AVispdprvLisgAdYxX/iEd6Ija4VI pMejSxgDg0z5Geee0Wzq1tEhp2tTPUg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-sAyyNNlwO0SWPY9ZJFU6kw-1; Thu, 23 Jul 2020 11:19:09 -0400 X-MC-Unique: sAyyNNlwO0SWPY9ZJFU6kw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0071857; Thu, 23 Jul 2020 15:19:08 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-87.ams2.redhat.com [10.36.112.87]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 82E16724CE; Thu, 23 Jul 2020 15:19:05 +0000 (UTC) Subject: Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs To: Peter Maydell References: <20200723132219.2956-1-thuth@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <381e22ef-0eef-cce4-2801-9066559ee30a@redhat.com> Date: Thu, 23 Jul 2020 17:19:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/22 22:13:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Guan Xuetao , Richard Henderson , QEMU Developers , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 23/07/2020 16.50, Peter Maydell wrote: > On Thu, 23 Jul 2020 at 14:23, Thomas Huth wrote: >> >> The dependency on curses has been removed in commit c7a856b42e403e2b >> ("target/unicore32: Prefer qemu_semihosting_log_out() over curses"). >> So we can remove the related lines in the Makefile now, too. >> >> Signed-off-by: Thomas Huth > > Reviewed-by: Peter Maydell > > Another, unrelated, CONFIG_CURSES oddity: > hw/input/virtio-input-hid.c has an "#undef CONFIG_CURSES" > before it includes ui/console.h. But that header file > doesn't do anything different if CONFIG_CURSES is defined, > so I think the undef is now useless and can be removed. There used to be some curses stuff in that header, but it has been removed more than two years ago (see commit b0766612d16da18). So yes, I think you're right, that #undef CONFIG_CURSES can be removed now. Care to send a patch? Thomas