qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Serge Guelton <sguelton@redhat.com>
Cc: Florian Weimer <fweimer@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: Portable inline asm to get address of TLS variable
Date: Thu, 17 Feb 2022 16:51:06 +0100	[thread overview]
Message-ID: <38223bfc-a90b-d91b-527e-3ad6c4c9e45e@redhat.com> (raw)
In-Reply-To: <20220217150216.GD11782@sguelton.remote.csb>

On 2/17/22 16:02, Serge Guelton wrote:
>>> I took a quick look at C++20 coroutines since they are available in
>>> compilers but the primitives look hard to use even from C++, let alone
>> >from C.
>>
>> They're C++ only in GCC, too.  I really think that QEMU should be
>> compilable in C++, but I'm not sure how easy a sell it is.
> It's perfectly fine to have one compilation unit written in C++ with a few
> symbol in `extern "C"`. No need to touch the other part of the project.

It's not just one compilation unit, it's everything that uses coroutines 
so basically all of block/.  But yes, good point---it means for example 
that you don't have to deal as much with lack of operators in C++ enums, 
which would be a huge PITA in compiling QEMU with C++.  There would 
still be some churn such as adding extern "C" blocks to headers, etc.

The main change with C++20 coroutines would be to introduce co_await, 
co_return and std::future<> everywhere, which is also a pretty 
substantial change (possibly an improvement in the case of co_await and 
co_return, but still a lot of work).

That said, it's certainly valuable to try and get at least 
tests/unit/test-coroutine.c to run with C++ coroutines, and see how much 
work that is.

Paolo


  parent reply	other threads:[~2022-02-17 16:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16 17:46 Portable inline asm to get address of TLS variable Stefan Hajnoczi
2022-02-16 18:13 ` Florian Weimer
2022-02-16 20:28   ` Stefan Hajnoczi
2022-02-16 20:33     ` Stefan Hajnoczi
2022-02-16 20:46       ` Florian Weimer
2022-02-17  9:30         ` Stefan Hajnoczi
2022-02-16 20:40     ` Florian Weimer
2022-02-17  9:28       ` Stefan Hajnoczi
2022-02-17 11:40         ` Paolo Bonzini
2022-02-17 15:02           ` Serge Guelton
2022-02-17 15:11             ` Stefan Hajnoczi
2022-02-17 15:51             ` Paolo Bonzini [this message]
2022-02-17 14:59         ` Serge Guelton
2022-03-01 11:54         ` Florian Weimer
2022-03-01 13:39           ` Stefan Hajnoczi
2022-04-19 11:32             ` Florian Weimer
2022-04-19 18:38               ` Thomas Rodgers
2022-04-20 14:12               ` Stefan Hajnoczi
2022-02-16 22:28 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38223bfc-a90b-d91b-527e-3ad6c4c9e45e@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sguelton@redhat.com \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).