From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] blockdev: Overlays are not snapshots
Date: Thu, 13 Jun 2019 21:41:23 +0200 [thread overview]
Message-ID: <382c9dae-c89e-983f-44c9-e7f1739a35b9@redhat.com> (raw)
In-Reply-To: <20190603202236.1342-1-mreitz@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 805 bytes --]
On 03.06.19 22:22, Max Reitz wrote:
> QEMU’s always been confused over what a snapshot is: Is it the overlay?
> Is it the backing image?
>
> Confusion is rarely a good thing. I can’t think of any objective reason
> why the overlay would be a snapshot. A snapshot is something that does
> not change over time; the overlay does.
>
> (I suppose historically the reason is that “Taking an overlay” makes no
> sense, so the operations are called “Taking a snapshot”. Somehow, this
> meaning carried over to the new file that is created during that
> operation; if “Creating a snapshot” creates a file, that file must be
> the snapshot, right? Well, no, it isn’t.)
>
> Let’s fix this as best as we can. Better Nate than lever.
Applied to my block branch.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-06-13 19:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 20:22 [Qemu-devel] [PATCH v2 0/2] blockdev: Overlays are not snapshots Max Reitz
2019-06-03 20:22 ` [Qemu-devel] [PATCH v2 1/2] qapi/block-core: " Max Reitz
2019-06-05 5:43 ` Markus Armbruster
2019-06-03 20:22 ` [Qemu-devel] [PATCH v2 2/2] blockdev: " Max Reitz
2019-06-03 22:09 ` [Qemu-devel] [Qemu-block] [PATCH v2 0/2] " John Snow
2019-06-04 8:40 ` Alberto Garcia
2019-06-13 19:41 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=382c9dae-c89e-983f-44c9-e7f1739a35b9@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).