From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05C9AC636D4 for ; Mon, 13 Feb 2023 14:24:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRZko-0005Jc-QH; Mon, 13 Feb 2023 09:24:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRZkm-0005Dq-ED for qemu-devel@nongnu.org; Mon, 13 Feb 2023 09:24:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRZkj-0001ws-W7 for qemu-devel@nongnu.org; Mon, 13 Feb 2023 09:24:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676298258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QSXH+UT/ENijXW1AQ5vXTQqj3NZWL0J+vOdgeUpC0yo=; b=DTxU3CFtj03ZFZzDFrbFDTEv2TcxKrAVmplxS8H8DU6JhzUR8U/EKgNE/ufJHC8d1GgVZl EFQcaIwmmSWnI9LOfz0tjMrevqFsF1G3yY2dtKMc75k5hS/D0WPHgbs00j70UmQW9n+l70 qpwot4EibJmMcJwGEMkACwb3VIX32bY= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-62-Ou0vKvfRMSST0-ZY0u4c3Q-1; Mon, 13 Feb 2023 09:24:15 -0500 X-MC-Unique: Ou0vKvfRMSST0-ZY0u4c3Q-1 Received: by mail-qk1-f200.google.com with SMTP id j29-20020a05620a001d00b00724fd33cb3eso7583496qki.14 for ; Mon, 13 Feb 2023 06:24:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QSXH+UT/ENijXW1AQ5vXTQqj3NZWL0J+vOdgeUpC0yo=; b=5ymdapDXaW64TUD+KaHetY11v1wfsqRXYrbDD2RR+qX1ofVThAk6lcowAE4C2Qdz/v jECQBOc5UVnnu2axG/Ix6JPUWGY4jYSrNgMrjWkhRlZ0hPGtuceF9yIYimCByRUMNXr7 YZsgOXjpvaYHV0Sp2beYNrNNj9FcWhX5Xb/j4DAXrrxE/VD8MD9DFpofL+kfzOhTDWOB pkcfZ2sEJp5IBE47gpJLHmYX+A2XfZnpk6PUrTm64FDlj7SHmgg5qx3ihp0vccV6iGS2 0FZ3pJecM4uXUXiRd1h3+HQgrmEE5WbDqjEOO31ElOFmbxOPLUqFJWfe1Jmz9RkkjbXC jGSg== X-Gm-Message-State: AO0yUKV7oHY7yik/ekBE9759MULBYrdN7dKw4Nd0IE2eoa32hd3cM7Wk Jm6amYTYNuXFUmtXKSP+PlPkMCa53+pSPXBjLYdbWWRzXckzlRyPWZzBrsoAgn6gBruDUkS0FCa W5Mm23QqRYnSNyus= X-Received: by 2002:ac8:5850:0:b0:3b6:3494:174 with SMTP id h16-20020ac85850000000b003b634940174mr46356537qth.52.1676298255001; Mon, 13 Feb 2023 06:24:15 -0800 (PST) X-Google-Smtp-Source: AK7set84s2VwveEBTXY8OemH9zgPdvqomnh+13LzXTcwZQCc1LMszZVSUfG/TUjyJ+Zfm9/wwYlkHQ== X-Received: by 2002:ac8:5850:0:b0:3b6:3494:174 with SMTP id h16-20020ac85850000000b003b634940174mr46356511qth.52.1676298254773; Mon, 13 Feb 2023 06:24:14 -0800 (PST) Received: from [192.168.0.2] (ip-109-43-177-185.web.vodafone.de. [109.43.177.185]) by smtp.gmail.com with ESMTPSA id r6-20020ae9dd06000000b0071d7ade87afsm9680329qkf.67.2023.02.13.06.24.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 06:24:13 -0800 (PST) Message-ID: <383a2e03-7ee9-cc93-72d5-7f039314f932@redhat.com> Date: Mon, 13 Feb 2023 15:24:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [RFC PATCH] Do not include "qemu/error-report.h" in headers that do not need it Content-Language: en-US To: Markus Armbruster Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-trivial@nongnu.org, Beniamino Galvani , Peter Maydell , Strahinja Jankovic , Coiby Xu , Gerd Hoffmann , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= References: <20230210111931.1115489-1-thuth@redhat.com> <87zg9lpre8.fsf@pond.sub.org> From: Thomas Huth In-Reply-To: <87zg9lpre8.fsf@pond.sub.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.345, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/02/2023 14.43, Markus Armbruster wrote: > Thomas Huth writes: > >> Include it in the .c files instead that use the error reporting >> functions. >> >> Signed-off-by: Thomas Huth >> --- >> RFC since it's more lines of code - but I think it's still cleaner >> this way. > > Yes, please! > > Reviewed-by: Markus Armbruster FWIW, I just noticed (thanks to the gitlab CI) that I was missing two more hunks: diff --git a/ui/dbus-console.c b/ui/dbus-console.c --- a/ui/dbus-console.c +++ b/ui/dbus-console.c @@ -22,6 +22,7 @@ * THE SOFTWARE. */ #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "qapi/error.h" #include "ui/input.h" #include "ui/kbd-state.h" diff --git a/ui/gtk.c b/ui/gtk.c --- a/ui/gtk.c +++ b/ui/gtk.c @@ -36,6 +36,7 @@ #include "qapi/qapi-commands-machine.h" #include "qapi/qapi-commands-misc.h" #include "qemu/cutils.h" +#include "qemu/error-report.h" #include "qemu/main-loop.h" #include "ui/console.h" Thomas