From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Peter Xu" <peterx@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>, "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] Fix socket chardev regression
Date: Tue, 21 Aug 2018 16:16:27 +0200 [thread overview]
Message-ID: <3842a5df-b3ed-08b3-b627-a89cd3c7c1ce@redhat.com> (raw)
In-Reply-To: <CAJ+F1C+qTV6gQa6SZJ_HLUP1YO0Nm2C-momg0nAZcV6TWPaREw@mail.gmail.com>
On 21/08/2018 16:04, Marc-André Lureau wrote:
>> If you don't like the way I proposed, another thing I am
>> thinking is that whether we can assign the gcontext for the chardev
>> backend before initialization of it (or by parsing the backend &
>> frontend relationships before init of backends), then we assure that
>> we never change the gcontext of any chardev backends. Though that
> Yes, I think that's a cleaner solution. I suggested to use an iothread
> argument in the cover letter.
That would be nice, but isn't it already too late for the monitor chardev?
In any case, I don't see a reason to dislike this patch, especially
since it comes with a testcase.
Paolo
next prev parent reply other threads:[~2018-08-21 14:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 13:52 [Qemu-devel] [PATCH 0/4] Fix socket chardev regression Marc-André Lureau
2018-08-17 13:52 ` [Qemu-devel] [PATCH 1/4] Revert "chardev: tcp: postpone TLS work until machine done" Marc-André Lureau
2018-08-17 13:52 ` [Qemu-devel] [PATCH 2/4] Revert "chardev: tcp: postpone async connection setup" Marc-André Lureau
2018-08-17 13:52 ` [Qemu-devel] [PATCH 3/4] char-socket: update all ioc handlers when changing context Marc-André Lureau
2018-08-17 13:52 ` [Qemu-devel] [PATCH 4/4] test-char: add socket reconnect test Marc-André Lureau
2018-08-20 2:45 ` [Qemu-devel] [PATCH 0/4] Fix socket chardev regression Peter Xu
2018-08-20 15:37 ` Marc-André Lureau
2018-08-21 6:29 ` Peter Xu
2018-08-21 14:04 ` Marc-André Lureau
2018-08-21 14:14 ` Daniel P. Berrangé
2018-08-21 14:16 ` Paolo Bonzini [this message]
2018-08-22 3:46 ` Peter Xu
2018-08-22 6:55 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3842a5df-b3ed-08b3-b627-a89cd3c7c1ce@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).