From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1FADC43603 for ; Fri, 20 Dec 2019 14:46:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D63B218AC for ; Fri, 20 Dec 2019 14:46:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (4096-bit key) header.d=crudebyte.com header.i=@crudebyte.com header.b="PJGAO8xd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D63B218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=crudebyte.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiJYO-00079d-JE for qemu-devel@archiver.kernel.org; Fri, 20 Dec 2019 09:46:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44571) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiJTy-0001sP-VN for qemu-devel@nongnu.org; Fri, 20 Dec 2019 09:42:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iiJTx-0001Jw-S1 for qemu-devel@nongnu.org; Fri, 20 Dec 2019 09:42:22 -0500 Received: from kylie.crudebyte.com ([5.189.157.229]:36883) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iiJTx-0001Bl-Be for qemu-devel@nongnu.org; Fri, 20 Dec 2019 09:42:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=gIZMH5ZTrXvAP1Rz9HE8IqlS0/3Jb4nNgyaeweODaHo=; b=PJGAO8xdooXxKwo/Sc3kDOzFPa DdYCG0IRxgXGKn+l3fuUlhKdg+YaYvmA3qLEPT9JFm/Ys9Sl1MLOKBZsQpMeqOQtD0z2gytLheyvZ 4Wmn1o0NFAUNYKBi+8OlYjv96EmNoF5D1R0tiVYSl198b3fjNQdpyqewKFNZ762y9HMKFlJ6iZ6pa 60Ch2IpCYrij5S0sqvYDAHN41cTIfADqeN1eY/G8/6Pud1JPkzNBdLD9UefJ7d9ApIS4MVJQmdR+O 8aiExGvB6GVlodJHif7ExNspN88CdjYwItkMXzrhIUwEMCMVxdENQ7bbZfWaJ4rMpI8Hg4bQaL7aS vPWGp2Hb1oFfGbq7zCQk7pfcxbarUj61aW3pkDkFxCgczPwTsYk+eeJVKKtbXJ9HWGec/6+hjYI7C vCSq7kpvQOrqkENrHr5xcmmDqsK/tua8EmxcvkowmK4lBoH/4KEODvyeSPZiiT3r+OQn2AsC4eozH J9aNEQy+QeFMUAJ+Gu2hn52pE9tGXRyvztMzBARniw8Lp2bgcYEqWyd+ESCMmVJjDFIPirnvreVB/ +/Xd6ps4bsOyvAnivcnPtO5D718QgICGlDToj5+4uUUxNoaTIOPA7XaNrJiaecTC4zJzefTyYYiE/ 6bWYUFRBFIw2AFsRcMyWaofcumZS222dxJyCv6ECc=; From: Christian Schoenebeck To: qemu-devel@nongnu.org Cc: Jiajun Chen , Greg Kurz , xiexiangyou@huawei.com Subject: Re: [PATCH] 9pfs: local: Fix possible memory leak in local_link() Date: Fri, 20 Dec 2019 15:42:17 +0100 Message-ID: <38461169.jQibMN2RfJ@silver> In-Reply-To: <20191220094934.21232-1-chenjiajun8@huawei.com> References: <20191220094934.21232-1-chenjiajun8@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.189.157.229 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Freitag, 20. Dezember 2019 10:49:34 CET Jiajun Chen wrote: > There is a possible memory leak while local_link return -1 without free > odirpath and oname. > > Reported-by: Euler Robot > Signed-off-by: Jaijun Chen > Signed-off-by: Xiang Zheng Reviewed-by: Christian Schoenebeck > --- > hw/9pfs/9p-local.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c > index 4708c0bd89..491b08aee8 100644 > --- a/hw/9pfs/9p-local.c > +++ b/hw/9pfs/9p-local.c > @@ -947,7 +947,7 @@ static int local_link(FsContext *ctx, V9fsPath *oldpath, > if (ctx->export_flags & V9FS_SM_MAPPED_FILE && > local_is_mapped_file_metadata(ctx, name)) { > errno = EINVAL; > - return -1; > + goto out; > } > > odirfd = local_opendir_nofollow(ctx, odirpath); Best regards, Christian Schoenebeck