From: Max Reitz <mreitz@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>,
Maxim Levitsky <mlevitsk@redhat.com>
Subject: Re: [PATCH] block/amend: Check whether the node exists
Date: Fri, 24 Jul 2020 09:01:53 +0200 [thread overview]
Message-ID: <3857a1b0-7f9d-57df-12b1-a223de0d7ee1@redhat.com> (raw)
In-Reply-To: <CAFEAcA_FmCSz=PnRm+CvZeZrdyM9spOZ6WwhcqFiS0Jak1+cXw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 816 bytes --]
On 23.07.20 19:56, Peter Maydell wrote:
> On Fri, 10 Jul 2020 at 10:51, Max Reitz <mreitz@redhat.com> wrote:
>>
>> We should check whether the user-specified node-name actually refers to
>> a node. The simplest way to do that is to use bdrv_lookup_bs() instead
>> of bdrv_find_node() (the former wraps the latter, and produces an error
>> message if necessary).
>>
>> Reported-by: Coverity (CID 1430268)
>> Fixes: ced914d0ab9fb2c900f873f6349a0b8eecd1fdbe
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>
> Hi; has this patch got lost? (I'm just running through the Coverity
> issues marked as fix-submitted to check the patches made it into
> master, and it looks like this one hasn't yet.)
Well, not strictly speaking lost, but I did forget to merge it, yes.
Thanks for the reminder!
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-24 7:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 9:50 [PATCH] block/amend: Check whether the node exists Max Reitz
2020-07-12 11:47 ` Maxim Levitsky
2020-07-23 17:56 ` Peter Maydell
2020-07-24 7:01 ` Max Reitz [this message]
2020-07-24 7:08 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3857a1b0-7f9d-57df-12b1-a223de0d7ee1@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).