From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: Re: [PATCH 1/2] tcg: Return TCGOp from tcg_gen_op[1-6]
Date: Tue, 10 Sep 2024 14:45:39 -0700 [thread overview]
Message-ID: <38703ae2-78d1-4727-9509-26065f650f98@linaro.org> (raw)
In-Reply-To: <20240910212351.977753-2-richard.henderson@linaro.org>
On 9/10/24 14:23, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/tcg-internal.h | 12 ++++++------
> tcg/tcg-op.c | 23 +++++++++++++++--------
> 2 files changed, 21 insertions(+), 14 deletions(-)
>
> diff --git a/tcg/tcg-internal.h b/tcg/tcg-internal.h
> index 52103f4164..8099248076 100644
> --- a/tcg/tcg-internal.h
> +++ b/tcg/tcg-internal.h
> @@ -92,12 +92,12 @@ TCGTemp *tcg_temp_new_internal(TCGType type, TCGTempKind kind);
> */
> TCGTemp *tcg_constant_internal(TCGType type, int64_t val);
>
> -void tcg_gen_op1(TCGOpcode, TCGArg);
> -void tcg_gen_op2(TCGOpcode, TCGArg, TCGArg);
> -void tcg_gen_op3(TCGOpcode, TCGArg, TCGArg, TCGArg);
> -void tcg_gen_op4(TCGOpcode, TCGArg, TCGArg, TCGArg, TCGArg);
> -void tcg_gen_op5(TCGOpcode, TCGArg, TCGArg, TCGArg, TCGArg, TCGArg);
> -void tcg_gen_op6(TCGOpcode, TCGArg, TCGArg, TCGArg, TCGArg, TCGArg, TCGArg);
> +TCGOp *tcg_gen_op1(TCGOpcode, TCGArg);
> +TCGOp *tcg_gen_op2(TCGOpcode, TCGArg, TCGArg);
> +TCGOp *tcg_gen_op3(TCGOpcode, TCGArg, TCGArg, TCGArg);
> +TCGOp *tcg_gen_op4(TCGOpcode, TCGArg, TCGArg, TCGArg, TCGArg);
> +TCGOp *tcg_gen_op5(TCGOpcode, TCGArg, TCGArg, TCGArg, TCGArg, TCGArg);
> +TCGOp *tcg_gen_op6(TCGOpcode, TCGArg, TCGArg, TCGArg, TCGArg, TCGArg, TCGArg);
>
> void vec_gen_2(TCGOpcode, TCGType, unsigned, TCGArg, TCGArg);
> void vec_gen_3(TCGOpcode, TCGType, unsigned, TCGArg, TCGArg, TCGArg);
> diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
> index eff3728622..28c41b37a4 100644
> --- a/tcg/tcg-op.c
> +++ b/tcg/tcg-op.c
> @@ -37,38 +37,43 @@
> */
> #define NI __attribute__((noinline))
>
> -void NI tcg_gen_op1(TCGOpcode opc, TCGArg a1)
> +TCGOp * NI tcg_gen_op1(TCGOpcode opc, TCGArg a1)
> {
> TCGOp *op = tcg_emit_op(opc, 1);
> op->args[0] = a1;
> + return op;
> }
>
> -void NI tcg_gen_op2(TCGOpcode opc, TCGArg a1, TCGArg a2)
> +TCGOp * NI tcg_gen_op2(TCGOpcode opc, TCGArg a1, TCGArg a2)
> {
> TCGOp *op = tcg_emit_op(opc, 2);
> op->args[0] = a1;
> op->args[1] = a2;
> + return op;
> }
>
> -void NI tcg_gen_op3(TCGOpcode opc, TCGArg a1, TCGArg a2, TCGArg a3)
> +TCGOp * NI tcg_gen_op3(TCGOpcode opc, TCGArg a1, TCGArg a2, TCGArg a3)
> {
> TCGOp *op = tcg_emit_op(opc, 3);
> op->args[0] = a1;
> op->args[1] = a2;
> op->args[2] = a3;
> + return op;
> }
>
> -void NI tcg_gen_op4(TCGOpcode opc, TCGArg a1, TCGArg a2, TCGArg a3, TCGArg a4)
> +TCGOp * NI tcg_gen_op4(TCGOpcode opc, TCGArg a1, TCGArg a2,
> + TCGArg a3, TCGArg a4)
> {
> TCGOp *op = tcg_emit_op(opc, 4);
> op->args[0] = a1;
> op->args[1] = a2;
> op->args[2] = a3;
> op->args[3] = a4;
> + return op;
> }
>
> -void NI tcg_gen_op5(TCGOpcode opc, TCGArg a1, TCGArg a2, TCGArg a3,
> - TCGArg a4, TCGArg a5)
> +TCGOp * NI tcg_gen_op5(TCGOpcode opc, TCGArg a1, TCGArg a2,
> + TCGArg a3, TCGArg a4, TCGArg a5)
> {
> TCGOp *op = tcg_emit_op(opc, 5);
> op->args[0] = a1;
> @@ -76,10 +81,11 @@ void NI tcg_gen_op5(TCGOpcode opc, TCGArg a1, TCGArg a2, TCGArg a3,
> op->args[2] = a3;
> op->args[3] = a4;
> op->args[4] = a5;
> + return op;
> }
>
> -void NI tcg_gen_op6(TCGOpcode opc, TCGArg a1, TCGArg a2, TCGArg a3,
> - TCGArg a4, TCGArg a5, TCGArg a6)
> +TCGOp * NI tcg_gen_op6(TCGOpcode opc, TCGArg a1, TCGArg a2, TCGArg a3,
> + TCGArg a4, TCGArg a5, TCGArg a6)
> {
> TCGOp *op = tcg_emit_op(opc, 6);
> op->args[0] = a1;
> @@ -88,6 +94,7 @@ void NI tcg_gen_op6(TCGOpcode opc, TCGArg a1, TCGArg a2, TCGArg a3,
> op->args[3] = a4;
> op->args[4] = a5;
> op->args[5] = a6;
> + return op;
> }
>
> /*
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
next prev parent reply other threads:[~2024-09-10 21:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 21:23 [PATCH 0/2] tcg: Fix branch/label link during plugin expansion Richard Henderson
2024-09-10 21:23 ` [PATCH 1/2] tcg: Return TCGOp from tcg_gen_op[1-6] Richard Henderson
2024-09-10 21:45 ` Pierrick Bouvier [this message]
2024-09-13 10:26 ` Alex Bennée
2024-09-13 20:50 ` Philippe Mathieu-Daudé
2024-09-10 21:23 ` [PATCH 2/2] tcg: Propagate new TCGOp to add_as_label_use Richard Henderson
2024-09-10 21:50 ` Pierrick Bouvier
2024-09-10 21:56 ` Richard Henderson
2024-09-10 21:28 ` [PATCH 0/2] tcg: Fix branch/label link during plugin expansion Richard Henderson
2024-09-13 10:23 ` Alex Bennée
2024-09-13 16:27 ` Richard Henderson
2024-09-18 18:43 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38703ae2-78d1-4727-9509-26065f650f98@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).