Re: [PATCH v5 2/2] tpm: add backend for mssim

[James Bottomley <jejb@linux.ibm.com>]

On Thu, 2023-01-05 at 11:20 -0500, Stefan Berger wrote:
> 
> 
> On 1/5/23 08:00, James Bottomley wrote:
[...]
> > +The mssim backend supports snapshotting and migration, but the
> > state
> > +of the Microsoft Simulator server must be preserved (or the server
> > +kept running) outside of QEMU for restore to be successful.
> 
> My comments to v3 still apply here.

You didn't make any v3 comments on migration.

> I also just tried migration and on the -incoming side it did not work
> anymore. Did you test this?

Well, yes, as I said.  However, I seem to have left one change in my
local tree which I forgot to sync to the patch:

diff --git a/backends/tpm/tpm_mssim.c b/backends/tpm/tpm_mssim.c
index 75dce165b8..125c8d0b15 100644
--- a/backends/tpm/tpm_mssim.c
+++ b/backends/tpm/tpm_mssim.c
@@ -66,7 +66,7 @@ static void tpm_mssim_instance_finalize(Object *obj)
 {
     TPMmssim *t = TPM_MSSIM(obj);
 
-    if (t->ctrl_qc && !runstate_check(RUN_STATE_INMIGRATE))
+    if (t->cmd_qc && !runstate_check(RUN_STATE_POSTMIGRATE))
         tpm_send_ctrl(t, TPM_SIGNAL_POWER_OFF, NULL);
 
     object_unref(OBJECT(t->ctrl_qc));

James