From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0uY0-000607-2Z for qemu-devel@nongnu.org; Wed, 19 Apr 2017 14:41:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0uXz-0003Nd-3R for qemu-devel@nongnu.org; Wed, 19 Apr 2017 14:41:48 -0400 References: <20170418221724.5707-1-ehabkost@redhat.com> <20170418221724.5707-4-ehabkost@redhat.com> <20170419002926.GC23273@umbus.fritz.box> <20170419014207.GT25239@thinpad.lan.raisama.net> <20170419140522.391f0b50.cornelia.huck@de.ibm.com> From: Marcel Apfelbaum Message-ID: <387c438e-d993-bd59-a59a-83c58d447eab@redhat.com> Date: Wed, 19 Apr 2017 21:41:19 +0300 MIME-Version: 1.0 In-Reply-To: <20170419140522.391f0b50.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 3/6] pci: Rename and change signatures of pci_bus_new() & related functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Eduardo Habkost Cc: David Gibson , qemu-devel@nongnu.org, aik@ozlabs.ru, David Gibson , "Michael S. Tsirkin" , Laszlo Ersek , Alexander Graf , Aurelien Jarno , Christian Borntraeger , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Paul Burton , Peter Maydell , Richard Henderson , Scott Wood , Yongbok Kim , qemu-arm@nongnu.org, qemu-ppc@nongnu.org On 04/19/2017 03:05 PM, Cornelia Huck wrote: > On Tue, 18 Apr 2017 22:42:07 -0300 > Eduardo Habkost wrote: > >> On Wed, Apr 19, 2017 at 10:29:26AM +1000, David Gibson wrote: >>> On Tue, Apr 18, 2017 at 07:17:21PM -0300, Eduardo Habkost wrote: >>>> pci_bus_new*() and pci_register_bus() work only when the 'parent' >>>> argument is a PCI_HOST_BRIDGE object. Rename them to reflect that they >>>> are meant to initialize a bus that's in a PCI host bridge. >>>> >>>> The new function names are: >>>> * pci_host_bus_init() (replacing pci_bus_new()) >>>> * pci_host_bus_init_inplace() (replacing pci_bus_new_inplace()) >>>> * pci_host_bus_init_irqs() (replacing pci_register_bus()) >>> >>> I like the idea, but I'm not terribly convinced by these names. >>> Aren't functions which allocate objects usually called whatever_new() >>> rather than whatever_init()? And pci_register_bus() appears to do >>> more than just initialize irqs. >> >> I agree the names aren't terribly clear. This is what they are >> supposed to mean: >> >> * pci_host_bus_init(phb) initializes phb->bus. >> * pci_host_bus_init(phb) initializes phb->bus using an >> already-allocated object. >> * pci_host_bus_init_irqs() does the same as pci_host_bus_init(), >> but also calls pci_bus_irqs(). >> >> I plan to submit API documentation comments later. I am open to >> alternative name suggestions. >> > > pci_host_bus_init_irqs() sounds as if it would only init irqs. What Right! This is what I thought too. > about: > > pci_host_bus_new() > pci_host_bus_new_inplace() > pci_host_bus_new_with_irqs() I like the names, but a following patch (5/6) modifies the above functions to return void and create the bus as a side effect. So now we have a pci_host_bus_new that returns nothing? Thanks, Marcel > > (the last one might be a bit long, though, especially as it takes so > many arguments already) >