From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52776)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1c9Ent-00052T-Gv
	for qemu-devel@nongnu.org; Tue, 22 Nov 2016 12:24:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1c9Ens-0008Tn-Il
	for qemu-devel@nongnu.org; Tue, 22 Nov 2016 12:24:21 -0500
References: <1479357400-17441-1-git-send-email-alastair@au1.ibm.com>
	<1479357400-17441-3-git-send-email-alastair@au1.ibm.com>
	<debe3f9c-d3ec-aad0-0424-7228bf60765b@kaod.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <3888651b-fd60-e827-a9f8-575a8f01be72@redhat.com>
Date: Tue, 22 Nov 2016 18:24:10 +0100
MIME-Version: 1.0
In-Reply-To: <debe3f9c-d3ec-aad0-0424-7228bf60765b@kaod.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/4] qtest: Support named interrupts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@kaod.org>, Alastair D'Silva <alastair@au1.ibm.com>, qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>, Andrew Jeffery <andrew@aj.id.au>, Joel Stanley <joel@jms.id.au>, Alastair D'Silva <alastair@d-silva.org>



On 22/11/2016 18:22, C=E9dric Le Goater wrote:
>> +
>> +        g_assert(words[1]); /* device */
>> +        g_assert(words[2]); /* gpio list */
>> +        g_assert(words[3]); /* gpio line in list */
>> +        g_assert(words[4]); /* level */
>> +        dev =3D DEVICE(object_resolve_path(words[1], NULL));
>> +        if (!dev) {
>> +            qtest_send_prefix(chr);
>> +            qtest_send(chr, "FAIL Unknown device\n");
>> +            return;
>> +        }
>> +
>> +        irq_num =3D atoi(words[3]);
>> +        level =3D atoi(words[4]);
>> +
>> +        QLIST_FOREACH(ngl, &dev->gpios, node) {
>> +            if (strcmp(words[2], ngl->name) =3D=3D 0 && ngl->num_in >=
 irq_num) {
>> +                irq =3D ngl->in[irq_num];
>> +            }
>> +        }
>> +
>> +        if (irq =3D=3D NULL) {
>> +            qtest_send_prefix(chr);
>> +            qtest_send(chr, "FAIL Unknown IRQ\n");
>> +            return;
>> +        }
>> +
>> +        qemu_set_irq(irq, level);

This seems wrong.  The IRQ should not be modifiable by the test.

Paolo

>> +
>> +        qtest_send_prefix(chr);
>> +        qtest_send(chr, "OK\n");