From: Alexander Graf <agraf@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] target-alpha, target-ppc: Remove unnecessary setjmp.h include
Date: Mon, 4 Jul 2011 23:45:47 +0200 [thread overview]
Message-ID: <3894AA64-4F23-416C-8DDF-EAC95AECAD51@suse.de> (raw)
In-Reply-To: <1309813366-7994-1-git-send-email-peter.maydell@linaro.org>
On 04.07.2011, at 23:02, Peter Maydell wrote:
> Remove the include of setjmp.h from the cpu.h of target-alpha
> and target-ppc. This is unnecessary because cpu-defs.h already
> includes this header; this change brings these two targets
> into line with all the rest.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Yeah, I actually think no code (unless specifically configure'd for it) should include non-local headers (<...> instead of "..."). Of course that would include device/target specific headers as well ;).
Acked-by: Alexander Graf <agraf@suse.de>
> ---
> target-alpha/cpu.h | 2 --
> target-ppc/cpu.h | 2 --
> 2 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h
> index 411bd55..78caa79 100644
> --- a/target-alpha/cpu.h
> +++ b/target-alpha/cpu.h
> @@ -28,8 +28,6 @@
>
> #include "cpu-defs.h"
>
> -#include <setjmp.h>
> -
> #include "softfloat.h"
>
> #define TARGET_HAS_ICE 1
> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> index 84f8ff6..d903366 100644
> --- a/target-ppc/cpu.h
> +++ b/target-ppc/cpu.h
> @@ -75,8 +75,6 @@
>
> #include "cpu-defs.h"
>
> -#include <setjmp.h>
> -
> #include "softfloat.h"
>
> #define TARGET_HAS_ICE 1
> --
> 1.7.4.1
>
>
next prev parent reply other threads:[~2011-07-04 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 21:02 [Qemu-devel] [PATCH] target-alpha, target-ppc: Remove unnecessary setjmp.h include Peter Maydell
2011-07-04 21:45 ` Alexander Graf [this message]
2011-07-12 21:29 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3894AA64-4F23-416C-8DDF-EAC95AECAD51@suse.de \
--to=agraf@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).