qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Halil Pasic <pasic@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices
Date: Fri, 1 Dec 2017 15:41:21 +0100	[thread overview]
Message-ID: <389e2efe-cbc5-8a78-e009-cd330d4ede6a@linux.vnet.ibm.com> (raw)
In-Reply-To: <bf78fad3-b6b2-bf82-2625-477233adb6cf@linux.vnet.ibm.com>



On 11/28/2017 04:21 PM, Halil Pasic wrote:
[..]
>>> Otherwise at first glance both patches seem sane.
>>
>> Can I count this as an ack, or do you plan to do more review?
>>
> 
> Yes I was planning to give it another look. And I do already
> have questions. Isn't the QOM composition tree API? I mean
> let's assume the QMP commands working on this tree are not completely
> useless. How is client code (management software) supposed to work,
> assumed it can rely on paths of e.g. properties being stable. Just
> imagine we had this default-cssid property (for the sake of the
> argument, not like we want it) on the css bridge.

Ping! I would like to get this clarified before proceeding with reviewing
this series.

> 
> Now if the composition tree is API then these can only be bug fixes
> (IMHO).
> 
> There are also other oddities I've spotted. My idea was to put
> this composition tree discussion on hold until the vfio-ccw stuff
> is sorted out. I would certainly like to build a better understanding.
> 
> Halil
> 

[..]

  reply	other threads:[~2017-12-01 19:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 13:46 [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices Cornelia Huck
2017-11-28 13:46 ` [Qemu-devel] [PATCH RFC 1/2] s390x/css: attach css bridge Cornelia Huck
2017-11-28 14:02   ` Christian Borntraeger
2017-12-08 11:43   ` Cornelia Huck
2017-11-28 13:46 ` [Qemu-devel] [PATCH RFC 2/2] s390x: attach autogenerated nics Cornelia Huck
2017-12-04 11:17   ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2017-12-04 16:40     ` Cornelia Huck
2017-12-04 17:33       ` Halil Pasic
2017-12-04 17:51         ` Cornelia Huck
2017-11-28 14:17 ` [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices Halil Pasic
2017-11-28 14:27   ` Cornelia Huck
2017-11-28 15:21     ` Halil Pasic
2017-12-01 14:41       ` Halil Pasic [this message]
2017-12-04  9:22         ` Cornelia Huck
2017-12-04 14:47           ` Halil Pasic
2017-12-04 16:51             ` Cornelia Huck
2017-12-04 11:47 ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2017-12-05  8:59 ` [Qemu-devel] " Bjoern Walk
2017-12-07 16:34   ` Cornelia Huck
2017-12-07 17:01     ` Halil Pasic
2017-12-07 17:06       ` Cornelia Huck
2017-12-07 17:15         ` Halil Pasic
2017-12-08 11:42           ` Cornelia Huck
2017-12-08 12:14             ` Halil Pasic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=389e2efe-cbc5-8a78-e009-cd330d4ede6a@linux.vnet.ibm.com \
    --to=pasic@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).