From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56ACAC433ED for ; Fri, 16 Apr 2021 18:02:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CED64610EA for ; Fri, 16 Apr 2021 18:02:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CED64610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXSn6-0005p2-Do for qemu-devel@archiver.kernel.org; Fri, 16 Apr 2021 14:02:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXS6x-00038N-QW for qemu-devel@nongnu.org; Fri, 16 Apr 2021 13:18:32 -0400 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:33758) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXS6s-0005bK-Fr for qemu-devel@nongnu.org; Fri, 16 Apr 2021 13:18:29 -0400 Received: by mail-pg1-x530.google.com with SMTP id t22so19674523pgu.0 for ; Fri, 16 Apr 2021 10:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=c3DYTZBvV6swFK3vz+GEyG8aP+VSchBb7eH8pGgdfes=; b=pg/grxdNZZhznUKwo5lJmSQiRG/YaQfBpbyyCA8NhZGlRmuPtJSFcuM72n8S7AVjta yJ/9jUvgmH9+JLO9CJOr6u53ZcP5wxGUIuw1ynTFDT93n2Ml7xNJ5+XX6ZHZE8mrLaBV oaFq4spArW59ENu9PI9OD5+278DWFcRq7HyUrBETkPubk7qFMes0RKpaHMzUF04WCFzk pqL726YZxr62+VtGG+9U13XChAtZKO8WnNe/PDrRvDxy66nZk1vUZAuBQAo7BzvY+47I ZR5u5Q1TMAMH7ZY9xwtI88v6hRNpfP4SpmRBNLveVMliic3KU6m8bcETIOPxifhWquMw FrXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c3DYTZBvV6swFK3vz+GEyG8aP+VSchBb7eH8pGgdfes=; b=I1JKwZ+Sag/OE/Xiy+rW5e+wG25Nac40qYt/HwmEnRkwAJWmA1XHhfM98BZZe+LXJ1 mY6J454i+Pv4yGmZiV7rzqgWWBF2NbfhCXwRDkc+dd+CXnFR+3Dp8Feyq84FTr5Xg4MQ dSjXtKsCdt+6aGfdsugYhFflH26Ew9Wk7Z1hwInv8iR4qzLH/jbKRcf0ynqsrDJKKE7F hlMvJd/2Wy2lgj0t5JZY9s5ECKjYL5Ubkm293xk9ZtP9xnutECfnHA11wu7t7xDZAWPb lqOB6YWVedX2PUzVVTji39w2vJQ9N8SRcfErQC+LwH1IPalmGEx+Ao14duxEv0neNa+a gFRg== X-Gm-Message-State: AOAM530NCG9BxHtYo+acdC2RHrbcVF9wVLEnK0xifA89ghBLCZD7uX0I nuOwm3jlP31jo3S+IFKa2oVheI6RaSUsaQ== X-Google-Smtp-Source: ABdhPJxapzLqNs5VLMjp8fGORzq8+3hz/th6dylwDqKyIHinD7tX1FeB3PANcc1SBMYbIObgaeKdPw== X-Received: by 2002:a63:f651:: with SMTP id u17mr150404pgj.148.1618593505108; Fri, 16 Apr 2021 10:18:25 -0700 (PDT) Received: from [192.168.1.11] ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id gi6sm2686084pjb.54.2021.04.16.10.18.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Apr 2021 10:18:24 -0700 (PDT) Subject: Re: [PATCH for-6.0? 5/6] include/qemu/bswap.h: Handle being included outside extern "C" block To: Peter Maydell , qemu-devel@nongnu.org References: <20210416135543.20382-1-peter.maydell@linaro.org> <20210416135543.20382-6-peter.maydell@linaro.org> From: Richard Henderson Message-ID: <38b7de66-2fcb-1fcf-d249-4c3558d393cb@linaro.org> Date: Fri, 16 Apr 2021 10:18:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210416135543.20382-6-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Daniel P. Berrange" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/16/21 6:55 AM, Peter Maydell wrote: > Make bswap.h handle being included outside an 'extern "C"' block: > all system headers are included first, then all declarations are > put inside an 'extern "C"' block. > > This requires a little rearrangement as currently we have an ifdef > ladder that has some system includes and some local declarations > or definitions, and we need to separate those out. > > We want to do this because dis-asm.h includes bswap.h, dis-asm.h > may need to be included from C++ files, and system headers should > not be included within 'extern "C"' blocks. > > Signed-off-by: Peter Maydell > --- > include/qemu/bswap.h | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~