From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tcg: Optionally log FPU state in TCG -d cpu logging
Date: Thu, 10 May 2018 07:36:17 -0700 [thread overview]
Message-ID: <38c06afb-389d-7e10-42b0-df1f8c2a23eb@twiddle.net> (raw)
In-Reply-To: <20180510130024.31678-1-peter.maydell@linaro.org>
On 05/10/2018 06:00 AM, Peter Maydell wrote:
> Usually the logging of the CPU state produced by -d cpu is sufficient
> to diagnose problems, but sometimes you want to see the state of
> the floating point registers as well. We don't want to enable that
> by default as it adds a lot of extra data to the log; instead,
> allow it to be optionally enabled via -d fpu.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I've found this helpful while tracking down fp-emulation related bugs.
>
> include/qemu/log.h | 1 +
> accel/tcg/cpu-exec.c | 9 ++++++---
> util/log.c | 2 ++
> 3 files changed, 9 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
I'll also note that only i386 and arm check this flag;
something to fix for the rest...
r~
next prev parent reply other threads:[~2018-05-10 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 13:00 [Qemu-devel] [PATCH] tcg: Optionally log FPU state in TCG -d cpu logging Peter Maydell
2018-05-10 14:36 ` Richard Henderson [this message]
2018-05-10 14:38 ` Peter Maydell
2018-05-11 10:00 ` Paolo Bonzini
2018-05-10 17:57 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38c06afb-389d-7e10-42b0-df1f8c2a23eb@twiddle.net \
--to=rth@twiddle.net \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).