From: Eric Blake <eblake@redhat.com>
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org, lvivier@redhat.com, dgilbert@redhat.com,
peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions"
Date: Wed, 6 Sep 2017 11:09:12 -0500 [thread overview]
Message-ID: <38c3884d-8e05-596a-acb8-80ae0530910d@redhat.com> (raw)
In-Reply-To: <87pob351o5.fsf@secure.mitica>
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On 09/06/2017 09:42 AM, Juan Quintela wrote:
> Eric Blake <eblake@redhat.com> wrote:
>> On 09/06/2017 06:51 AM, Juan Quintela wrote:
>>> This reverts commit d4622e55883211072621958d39ddaa73483d201e.
>>
>> But with no reason why? What bugs are you fixing by reverting this?
>
> I put it on the cover letter. I am investigating *why* it fails on me.
> It got the thread handed.
Then I think I ran into the same problems as you (NBD was hanging for me
due to the nested event loop being called from a coroutine context),...
>
> My plan is to fix whatever is there and see why it is failing.
>
>> Also, have you seen my patches, that also fix bugs in the _all functions?
>> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01053.html
>
> No, I have to take a look, thanks.
...and hopefully my patch helps the hang you were seeing (now in a pull
request:
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01338.html).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-09-06 16:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 11:51 [Qemu-devel] [PATCH v7 00/22] Multifd Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions" Juan Quintela
2017-09-06 14:00 ` Eric Blake
2017-09-06 14:42 ` Juan Quintela
2017-09-06 16:09 ` Eric Blake [this message]
2017-09-06 16:32 ` Daniel P. Berrange
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 02/22] migration: Create migration_ioc_process_incoming() Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 03/22] migration: Teach it about G_SOURCE_REMOVE Juan Quintela
2017-09-08 17:18 ` Dr. David Alan Gilbert
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 04/22] migration: Add comments to channel functions Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 05/22] migration: Create migration_has_all_channels Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 06/22] migration: Improve migration thread error handling Juan Quintela
2017-09-06 19:04 ` Dr. David Alan Gilbert
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 07/22] migration: Make migrate_fd_error() the owner of the Error Juan Quintela
2017-09-06 16:15 ` Eric Blake
2017-09-07 11:53 ` Juan Quintela
2017-09-11 18:58 ` Dr. David Alan Gilbert
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 08/22] qio: Create new qio_channel_{readv, writev}_all Juan Quintela
2017-09-06 14:03 ` Eric Blake
2017-09-06 14:11 ` Daniel P. Berrange
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 09/22] migration: Add multifd capability Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 10/22] migration: Create x-multifd-threads parameter Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 11/22] migration: Create x-multifd-group parameter Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 12/22] migration: Create multifd migration threads Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 13/22] migration: Split migration_fd_process_incoming Juan Quintela
2017-09-08 17:22 ` Dr. David Alan Gilbert
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 14/22] migration: Start of multiple fd work Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 15/22] migration: Create ram_multifd_page Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 16/22] migration: Really use multiple pages at a time Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 17/22] migration: Send the fd number which we are going to use for this page Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 18/22] migration: Create thread infrastructure for multifd recv side Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 19/22] migration: Test new fd infrastructure Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 20/22] migration: Rename initial_bytes Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 21/22] migration: Transfer pages over new channels Juan Quintela
2017-09-06 11:51 ` [Qemu-devel] [PATCH v7 22/22] migration: Flush receive queue Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38c3884d-8e05-596a-acb8-80ae0530910d@redhat.com \
--to=eblake@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).