From: Thomas Huth <thuth@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>,
Elena Afanasova <eafanasova@gmail.com>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
jasowang@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame
Date: Mon, 12 Oct 2020 12:44:56 +0200 [thread overview]
Message-ID: <38d5993e-8a10-0fb1-5263-6531a356fefd@redhat.com> (raw)
In-Reply-To: <20201012053001.GD4787@yekko.fritz.box>
On 12/10/2020 07.30, David Gibson wrote:
> On Sat, Oct 10, 2020 at 08:53:00AM -0700, Elena Afanasova wrote:
>> On Sat, 2020-10-10 at 17:07 +1100, David Gibson wrote:
>>> On Fri, Oct 09, 2020 at 07:02:56AM -0700, Elena Afanasova wrote:
>>>>> From 09905773a00e417d3a37c12350d9e55466fdce8a Mon Sep 17 00:00:00
>>>>> 2001
>>>> From: Elena Afanasova <eafanasova@gmail.com>
>>>> Date: Fri, 9 Oct 2020 06:41:36 -0700
>>>> Subject: [PATCH] hw/net: move allocation to the heap due to very
>>>> large stack
>>>> frame
>>>
>>> Patch looks fine, but some more details of the motivation would be
>>> nice. I wouldn't have thought that the size of a network packet
>>> counted as a "very large" stack frame by userspace standards.
>>>
>>
>> gcc with wstack-usage warns that stack frame size may be ~65Kbytes
>
> AFAICT, -Wstack-usage takes a parameter giving what size it will
> complain about. What was that value, and what was the rationale for
> choosing it?
I think this is one of the tasks from:
https://wiki.qemu.org/Contribute/BiteSizedTasks#Compiler-driven_cleanups
It has been added by Paolo in 2016:
https://wiki.qemu.org/index.php?title=Contribute/BiteSizedTasks&diff=5368&oldid=5367
... so maybe Paolo can comment on the size that has been chosen here...?
Thomas
next prev parent reply other threads:[~2020-10-12 10:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 14:02 [PATCH] hw/net: move allocation to the heap due to very large stack frame Elena Afanasova
2020-10-09 14:14 ` Richard Henderson
2020-10-09 14:25 ` Philippe Mathieu-Daudé
2020-10-09 14:48 ` Greg Kurz
2020-10-09 14:55 ` Li Qiang
2020-10-10 6:07 ` David Gibson
2020-10-10 15:53 ` Elena Afanasova
2020-10-12 5:30 ` David Gibson
2020-10-12 10:44 ` Thomas Huth [this message]
2020-10-12 13:45 ` Paolo Bonzini
2020-10-13 5:32 ` David Gibson
2020-10-14 14:15 ` Elena Afanasova
2020-10-16 0:32 ` David Gibson
2020-10-11 2:23 ` Li Qiang
2020-10-12 5:28 ` David Gibson
2020-10-12 11:09 ` Philippe Mathieu-Daudé
2020-10-12 11:48 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38d5993e-8a10-0fb1-5263-6531a356fefd@redhat.com \
--to=thuth@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=eafanasova@gmail.com \
--cc=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).