From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH v4 03/10] tests/qtest: get rid of 'qmp_command' helper in migration test
Date: Fri, 2 Jun 2023 09:52:05 +0200 [thread overview]
Message-ID: <38d8b6a0-abb4-3e00-8f6f-d8caaaca26fc@redhat.com> (raw)
In-Reply-To: <20230601161347.1803440-4-berrange@redhat.com>
On 01/06/2023 18.13, Daniel P. Berrangé wrote:
> This function duplicates logic of qtest_qmp_assert_success_ref.
> The qtest_qmp_assert_success_ref method has better diagnostics
> on failure because it prints the entire QMP response, instead
> of just asserting on existance of the 'error' key.
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/qtest/migration-helpers.c | 22 ----------------------
> tests/qtest/migration-helpers.h | 3 ---
> tests/qtest/migration-test.c | 29 +++++++++++++++--------------
> 3 files changed, 15 insertions(+), 39 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-06-02 7:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 16:13 [PATCH v4 00/10] tests/qtest: make migration-test massively faster Daniel P. Berrangé
2023-06-01 16:13 ` [PATCH v4 01/10] tests/qtest: add various qtest_qmp_assert_success() variants Daniel P. Berrangé
2023-06-01 22:44 ` Juan Quintela
2023-06-01 16:13 ` [PATCH v4 02/10] tests/qtest: add support for callback to receive QMP events Daniel P. Berrangé
2023-06-01 22:45 ` Juan Quintela
2023-06-02 7:51 ` Thomas Huth
2023-06-01 16:13 ` [PATCH v4 03/10] tests/qtest: get rid of 'qmp_command' helper in migration test Daniel P. Berrangé
2023-06-02 7:52 ` Thomas Huth [this message]
2023-06-01 16:13 ` [PATCH v4 04/10] tests/qtest: get rid of some 'qtest_qmp' usage " Daniel P. Berrangé
2023-06-01 16:13 ` [PATCH v4 05/10] tests/qtest: switch to using event callbacks for STOP event Daniel P. Berrangé
2023-06-01 16:13 ` [PATCH v4 06/10] tests/qtest: replace wait_command() with qtest_qmp_assert_success Daniel P. Berrangé
2023-06-01 16:13 ` [PATCH v4 07/10] tests/qtest: capture RESUME events during migration Daniel P. Berrangé
2023-06-02 7:45 ` Juan Quintela
2023-06-01 16:13 ` [PATCH v4 08/10] tests/qtest: distinguish src/dst migration VM stop/resume events Daniel P. Berrangé
2023-06-01 22:47 ` Juan Quintela
2023-06-01 16:13 ` [PATCH v4 09/10] tests/qtest: make more migration pre-copy scenarios run non-live Daniel P. Berrangé
2023-06-01 22:50 ` Juan Quintela
2023-06-01 16:13 ` [PATCH v4 10/10] tests/qtest: massively speed up migration-test Daniel P. Berrangé
2023-06-01 17:29 ` [PATCH] qtest/migration: Document live=true cases Peter Xu
2023-06-01 18:22 ` Daniel P. Berrangé
2023-06-01 22:52 ` Juan Quintela
2023-07-03 16:37 ` [PATCH v4 00/10] tests/qtest: make migration-test massively faster Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38d8b6a0-abb4-3e00-8f6f-d8caaaca26fc@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=leobras@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).