From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
qemu-block@nongnu.org, "Richard Henderson" <rth@twiddle.net>,
"Peter Lieven" <pl@kamp.de>,
qemu-devel@nongnu.org, "Laurent Vivier" <laurent@vivier.eu>,
"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
"Max Reitz" <mreitz@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH v3 01/11] qapi: Restrict query-uuid command to block code
Date: Thu, 1 Oct 2020 12:22:12 +0200 [thread overview]
Message-ID: <38e2b34b-7bb8-9e4b-680c-22e1fd21c3ef@redhat.com> (raw)
In-Reply-To: <87r1qi4jvj.fsf@dusky.pond.sub.org>
+Igor
On 10/1/20 7:04 AM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>
>> In commit f68c01470b we restricted the query-uuid command to
>> machine code, but it is incorrect, as it is also used by the
>> tools. Therefore move this command again, but to block.json,
>> which is shared by machine code and tools.
>>
>> Fixes: f68c01470b ("qapi: Restrict query-uuid command to machine code")
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> UUIDs are not really a block-specific thing.
This is the discussion we had in v1 with Igor...
UuidInfo is a iSCSI-specific "thing", the original commit
is f9dadc9855 ("iSCSI: add configuration variables for iSCSI")
then Paolo introduced 'UuidInfo' in commit 5accc8408f
("scsi: prefer UUID to VM name for the initiator name") but
is misnamed?
>
> QMP query-uuid and HMP info uuid are about the VM, like query-name.
> That's why they used to be next to query-name in misc.json.
This is GuidInfo, not UuidInfo...
GuidInfo is correctly in machine.json.
>
> There's one additional use in block/iscsi.c's get_initiator_name(). I
> figure that's what pulls it into tools via qemu-img.
Yes.
>
> Which other QAPI modules are shared by all the executables that use it?
None?
>
> What about reverting the commit? How bad would that be for user mode?
>
The problem is not user-mode, is linking tools.
next prev parent reply other threads:[~2020-10-01 10:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 16:49 [PATCH v3 00/11] user-mode: Prune build dependencies (part 3) Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 01/11] qapi: Restrict query-uuid command to block code Philippe Mathieu-Daudé
2020-10-01 5:04 ` Markus Armbruster
2020-10-01 10:22 ` Philippe Mathieu-Daudé [this message]
2020-10-01 12:24 ` Markus Armbruster
2020-09-30 16:49 ` [PATCH v3 02/11] hw/core/qdev-properties: Use qemu_strtol() in set_mac() handler Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 03/11] hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr() Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 04/11] hw/core/qdev-properties: Fix code style Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 05/11] hw/core/qdev-properties: Export enum-related functions Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 06/11] hw/core/qdev-properties: Export qdev_prop_enum Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 07/11] hw/core/qdev-properties: Export some integer-related functions Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 08/11] hw/core/qdev-properties: Extract system-mode specific properties Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 09/11] hw/core: Add qdev stub for user-mode Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 10/11] target/i386: Restrict X86CPUFeatureWord to X86 targets Philippe Mathieu-Daudé
2020-09-30 17:18 ` Eduardo Habkost
2020-09-30 16:49 ` [PATCH v3 11/11] qapi: Restrict code generated for user-mode Philippe Mathieu-Daudé
2020-10-01 5:09 ` Markus Armbruster
2020-10-01 10:23 ` Philippe Mathieu-Daudé
2020-09-30 17:15 ` [PATCH v3 00/11] user-mode: Prune build dependencies (part 3) Eduardo Habkost
2020-09-30 17:24 ` Paolo Bonzini
2020-09-30 17:27 ` Eduardo Habkost
2020-10-01 12:56 ` Philippe Mathieu-Daudé
2020-09-30 18:56 ` Alex Bennée
2020-09-30 19:05 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38e2b34b-7bb8-9e4b-680c-22e1fd21c3ef@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).